Skip to content

Fix some issues with qtfred's ship list dialog#7329

Open
MjnMixael wants to merge 1 commit intoscp-fs2open:masterfrom
MjnMixael:qtfred_ship_list_fixes
Open

Fix some issues with qtfred's ship list dialog#7329
MjnMixael wants to merge 1 commit intoscp-fs2open:masterfrom
MjnMixael:qtfred_ship_list_fixes

Conversation

@MjnMixael
Copy link
Copy Markdown
Contributor

Fixes a few things here:

  1. Waypoints in the list were having their name copied with characters past the null terminator causing junk characters to appear in the string.
  2. Waypoints were being pushed to the wing list in a clear copy/paste error.
  3. Fix a heap crash by changing it so that objectSelectionChanged() no longer uses model()->match() which returns a QList. These QModelIndex objects are heap-allocated inside Qt's DLL, but freed by the CRT causing an MSVC debug heap boundary violation.

@MjnMixael MjnMixael added the qtfred A feature or issue related to qtFred. label Mar 30, 2026
@github-project-automation github-project-automation bot moved this to Work In Progress (PRs) in qtFRED2 Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

qtfred A feature or issue related to qtFred.

Projects

Status: Work In Progress (PRs)

Development

Successfully merging this pull request may close these issues.

1 participant