Fix targest nearest attacking ship in multiplayer#7326
Open
wookieejedi wants to merge 3 commits intoscp-fs2open:masterfrom
Open
Fix targest nearest attacking ship in multiplayer#7326wookieejedi wants to merge 3 commits intoscp-fs2open:masterfrom
targest nearest attacking ship in multiplayer#7326wookieejedi wants to merge 3 commits intoscp-fs2open:masterfrom
Conversation
Pressing 'Target Nearest Attacker` in multiplayer does not work when a ship has spontaneously targeted another ship. This is because within, `multi_oo_pack_data` `goals[0].target_name` only covers explicitly ordered goal targets and is empty for spontaneous IFF-based engagements, which means `target_signature` does not return the proper value. This PR adds an extra check for that to pefer the live target_objnum so clients know who is actually being attacked. Tested and works as expected.
wookieejedi
added
fix
notimaginative
requested changes
Mar 29, 2026
Contributor
notimaginative
left a comment
notimaginative
left a comment
There was a problem hiding this comment.
These comments really need to be sorted out. There are 3 lines of comments which shouldn't have been changed at all, and having 4 lines worth of comments before an else should really be no-no.
Member
Author
|
Good points, just pushed an update, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pressing 'Target Nearest Attacker
in multiplayer does not work when a ship has spontaneously targeted another ship. This is because within,multi_oo_pack_dataonly covers explicitly ordered goal targets and is empty for spontaneous IFF-based engagements, which meanstarget_signature` does not return the proper value. This PR adds an extra check for that to pefer the live target_objnum so clients know who is actually being attacked.Tested and works as expected.