Unified briefing map render paths#7309
Open
MjnMixael wants to merge 4 commits intoscp-fs2open:masterfrom
Open
Conversation
MjnMixael
added
the
cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QtFRED's briefing editor dialog is going to use the same map rendering paths as in-game. SCPUI does also, but back when I wrote the API for that I split them into distinct functions, mostly because I was less experienced.
It's time to merge those paths back into one with the api_access bool, same as we've done for all the other ui api exposed methods. This PR should change no functionality so the review should double check that both paths run all the same code as they did before, just now gated behind the bool as appropriate.
This will also likely help find and fix issue #7302 as it was confirmed to me that it happens in both rendering paths.