address issues with multi interpolation code#7306
address issues with multi interpolation code#7306notimaginative wants to merge 15 commits intoscp-fs2open:masterfrom
Conversation
The check was expanded and moved below this, but the old version remained.
If a ship is destroyed we still need to continue processing any other ships in the list.
Afterburn hack is to fix trails and model animations getting triggered so that clients and hosts see them. The hack needs to be reset before multi_oo_unpack_client_data() though, not after. Fixes behavior that was broken in scp-fs2open#2752
Add safety checks for signal updates to avoid array boundary issues. And be sure to reasses packet indexes when a new packet arrives instead of waiting a frame for index updates.
Could cause ships to jump backwards during position updates.
|
So essentially, it looks like this should be a big improvement, and I think it's fine for it to be approved. Just so that no one accidentally merges early before testing, I am not actually hitting the approve button. |
|
Testing on this build reveals the skipping issue I had occasionally run into before seems fixed, too. |
Fixes timing bug that used the wrong timestamp for primary and secondary weapon shots on clients. This resulted in a discrepancy between client and server timing which caused weapon shots to bypass the rollback system and become unreliable.
Put ships getting whacked by weapons or other objects into simulation mode to avoid odd position changes when client-side whacks get overridden by server interoplation updates.
|
Deploying it to an FotG standalone for testing now. In the meantime, spent some tokens on analysis and got this back.
Do with that what you will, doesn't sound like critical flaws or anything to me. |
Collection of fixes for multiple issues with the multi code found by Claude AI (by way of Goober5000), plus additional issues noted by myself while checking the code. These fixes are primarily focused on the interpolation code.
These changes should not be breaking and are largely exclusive to server-side handling, but still need to be tested thoroughly before being merged. Any tests must be done with at least the server (master) using the fixes.
Setting for 26.0 milestone to allow appropriate time to test.