Open
Conversation
Merged
MjnMixael
force-pushed
the
qtfred-sexp-tree-refactor
branch
from
82e332d to
ec76cc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the long-promised sexp_tree refactor. The main goal was to move all logic out of FRED's sexp_tree.cpp into a model that could be shared between both FRED and QtFRED. This would not only simplify how much duplicate maintenance we have to do but would also open up sexp editing to new kinds of UIs layered on top (such as the graph editor as requested in #4809 .
The model ended up being split into 4 files: the main sexp tree model, an actions helper, an OPF helper, and an Event Annotations model. While reviewing it may be helpful to start with the main model, then actions and opf, then events. Then with that knowledge take a look at the old sexp_tree files (renamed to sexp_tree_view).
I'm making builds of FRED available to mission designers for testing as well while the review process gets under way.
Because of how intertwined the logic and UI was in sexp_tree I did not see an easy way to split this up into manageable pieces. I'm so sorry.
Fixes #6982