Skip to content

port to SDL3#7220

Open
notimaginative wants to merge 1 commit intoscp-fs2open:masterfrom
notimaginative:sdl3_port
Open

port to SDL3#7220
notimaginative wants to merge 1 commit intoscp-fs2open:masterfrom
notimaginative:sdl3_port

Conversation

@notimaginative
Copy link
Copy Markdown
Contributor

Basic port from SDL2 to SDL3. Also updates imgui to 1.92.5.

@notimaginative notimaginative added this to the Release 26.0 milestone Feb 12, 2026
@notimaginative
Copy link
Copy Markdown
Contributor Author

notimaginative commented Feb 12, 2026

This is the basic port, and other SDL3-related feature PRs will come after this is merged.

One notable issue is that setting of gamma needs to be done by shaders as the gamma feature was removed from SDL3. Someone with a much better understanding of the current graphics code, and shaders in particular, should probably take care of that.

@wookieejedi wookieejedi added the refactor A cleanup/restructure of a feature for speed, simplicity, and/or maintainability label Feb 13, 2026
@wookieejedi
Copy link
Copy Markdown
Member

@BMagnu is the Gamma shader aspect mentioned above something that you would be willing to comment on?

@wookieejedi
Copy link
Copy Markdown
Member

If I start in windowed mode, then switch to fullscreen mode the screen flickers. It contines to flicker if in fullscreen mode upon game restart as well. This does not happen via windowed mode, so it is likely that the SDL 3 PR inadvertently reverted a bug fix we have in master for this screen flickering
Possibly to PR #6767 or related ones

@notimaginative
Copy link
Copy Markdown
Contributor Author

If I start in windowed mode, then switch to fullscreen mode the screen flickers. It contines to flicker if in fullscreen mode upon game restart as well. This does not happen via windowed mode, so it is likely that the SDL 3 PR inadvertently reverted a bug fix we have in master for this screen flickering Possibly to PR #6767 or related ones

I don't remember seeing this, but I rarely use fullscreen mode. Or it simply might not happen on Mac. I'll check it out when I get the chance.

PR #6767 is still in there however, and wasn't altered for the port.

@wookieejedi
Copy link
Copy Markdown
Member

Oh indeed, hmm yeah it's odd. At the very least it is always reproducible for me, so happy to do any local testing on Windows as we might need.

@notimaginative notimaginative force-pushed the sdl3_port branch 2 times, most recently from 3184bad to 37618ee Compare March 25, 2026 20:41
@notimaginative
Copy link
Copy Markdown
Contributor Author

Squashed in fixes for the fullscreen bug as well as disabling the changing of display resolution at runtime. Both commits are available individually as part of #6735 for anyone that would like to see them without all the rest of the changes.

Basic port from SDL2 to SDL3. Also updates imgui to 1.92.5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor A cleanup/restructure of a feature for speed, simplicity, and/or maintainability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants