Fix build issue on macOS (aarch64, gcc) and use debugtrap wherever possible #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
debugbreakprefer__builtin_debugtrap()wherever it's available (clang).The code snippet I've used is @jwakely's work, I've added a signoff to my commit message to mark the original author.
The patch fixes a build issue too on macOS (Apple silicon) when a real GCC compiler is used:
Depends on #22
Fixes #24
I'm testing this change on the following architectures (with clang + gcc):
Unfortunately, I won't be able to test the change on riscv and powerpc.