fix: completion generation inside $() #1403
Draft
+69
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Command substitution completion was incorrectly setting the `prev` variable due to the `_comp_initialize` function reassigning it from the original completion context after processing the substitution. The fix ensures that `words` and `cword` variables are also updated to match the command substitution context, preventing the later reassignment from overriding the correct `prev` value. Unit test added to validate command substitution correctly sets `COMP_LINE`, `COMP_CWORD`, `cur`, and `prev` variables for both single commands and commands with arguments.
richardkmichael
force-pushed
the
completion-in-csub
branch
from
2b82879 to
550e0cd
Compare
yedayak
reviewed
Jul 24, 2025
Collaborator
yedayak
left a comment
yedayak
left a comment
There was a problem hiding this comment.
In main echo $(ip <TAB> completes all files (the default completion, it should complete sub-commands), but with this PR it doesn't complete anything. Maybe you can use _comp_command_offset for this?
| # Replace the completion variables with ones that reflect the inner context. | ||
| COMP_LINE=$inner_line | ||
| read -ra COMP_WORDS <<<"$inner_line" | ||
| COMP_CWORD=$((${#COMP_WORDS[@]} - 1)) |
Collaborator
There was a problem hiding this comment.
This can become negative if there isn't anything inside the $():
echo $(<TAB>bash: COMP_WORDS: bad array subscript
Author
|
@yedayak Thanks for the quick review. I'll investigate. |
scop
requested changes
Oct 12, 2025
Owner
scop
left a comment
scop
left a comment
There was a problem hiding this comment.
Just a note to set "changes requested" per earlier comments so this shows up as such in PR list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #630
python -m pytest test/t/unithas two failing tests and two skipped tests intest_unit_compgen_filedir.py. This is the same as onmain, so I do not believe they are related to this patch.python -m mypy .andpython -m ruff checpassI am unsure what to make of the
runLintoutput, but it has exit status0, so I presume it is OK