Add metadata NeXus writing #663
Merged
+226
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YooSunYoung
reviewed
Jan 22, 2026
src/scippneutron/metadata/_model.py
Outdated
| _create_optional_nexus_field(group, 'address', self.address) | ||
| _create_optional_nexus_field(group, 'affiliation', self.affiliation) | ||
| _create_optional_nexus_field(group, 'email', self.email) | ||
| _create_optional_nexus_field(group, 'name', self.name) |
Member
Author
There was a problem hiding this comment.
It is in nexus but not in scippneutron. Changed
YooSunYoung
reviewed
Jan 22, 2026
src/scippneutron/metadata/_model.py
Outdated
| _create_optional_nexus_field(group, 'address', self.address) | ||
| _create_optional_nexus_field(group, 'affiliation', self.affiliation) | ||
| _create_optional_nexus_field(group, 'email', self.email) | ||
| _create_optional_nexus_field(group, 'name', self.name) |
Member
There was a problem hiding this comment.
It looks like it's not optional based on the tests and reader.
Suggested change
| _create_optional_nexus_field(group, 'name', self.name) | |
| snx.create_field(group, 'name', self.name) |
YooSunYoung
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for writing some metadata models to NeXus files via ScippNexus'
__write_to_nexus_group__hook. Inspired by scipp/essnmx#187 and scipp/scippnexus#289I stuck with standard NeXus fields and attributes and didn't add support anything beyond that. I also didn't implement this for Measurement and Beamline because they are not written to their own isolated group but are mixed with a bunch of other fields. And I am unsure how that would be used in practice.