Speedup rectangle mode for inspector plot

[nvaytet]

We use slicing for rectangle tool instead of masking like a polygon.
This yields a very large speedup.
Try out this on main and in this speedup-rectangle-inspector branch:

import plopp as pp
from plopp.data.examples import clusters3d

N = 512
da = clusters3d(nclusters=500, seed=12).hist(z=N, y=N, x=N)

pp.inspector(da, dim='z', mode='rectangle', logc=True)

[SimonHeybrock]

I presume the exclusive bounds are intentional?

[nvaytet]

Do you mean that if we have a max value that falls exactly on a bin edge, the bin to the right of that won't be included?
I think that's it what we want?

If I draw a rectangle exactly from 15 to 20, then I want the cells from the left edge at 15 to the right edge at 20 to be included.
I don't want the cell with a right edge at 15 and the one with left edge at 20 to be included. Right?

[SimonHeybrock]

I don't know. We have made that decision for slicing, but I am not sure the same is valid for a UI and drawing a rectangle — a user might expect both bounds to be inclusive?

[nvaytet]

This indicates a slight behaviour change:
before a cell was only included if its center was in the rectangle, now it's as soon as one edge is in the rectangle.
This makes little difference for data with a large resolution.

Which is the correct one is difficult to decide. When the operation we perform at the end is a sum, we would probably want to just rebin at the exact position of the rectangle edge, to include a fraction of an incomplete bin.
But if the operation is something else, it is not clear what should actually be done.

I think it's fine for now, it's probably what most users would expect.
If some fine tuning is needed for a specific application we can either revisit or make a custom selection function and inject that in the inspector (somehow).