Load time-dependent transformations from NeXus#246
Conversation
021f15c to
fbd43c4
Compare
|
This causes an issue with the class Position(sciline.Scope[Component, RunType, sc.Variable | sc.DataArray], sc.Variable | sc.DataArray):But that is not possible because we can't inherit from unions. So I'm thinking we could always make positions data arrays. But that impacts a lot of downstream code that currently expects variables. But that code is anyway broken for dime dependent positions and might need an update. Alternatively, we could use a separate path through the workflow and add class MovingPosition(sciline.Scope[Component, RunType, sc.DataArray], sc.DataArray):and providers then have to request that type when they can deal with time dependence. The providers constructing Thoughts? (@SimonHeybrock, @nvaytet) |
The previous attempt added the time as an event coord. This makes grouping by time-dependent coords more difficult down the line. It is not apparent which event coords depend on a slow timescale that we might later want to group or bin into and which coords truly depend on the events.
Needed for vector lookup.
2a49cd8 to
407d815
Compare
Still testing with BIFROST to see if this is what we need.