-
Notifications
You must be signed in to change notification settings - Fork 8
New SBI models from anya #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
djones1040
wants to merge
20
commits into
main
Choose a base branch
from
djones-sbi-update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
031b474
new SNR files
djones1040 ded909d
new sbipp model files
djones1040 d7c55a5
removed photo-z estimation
djones1040 cf9968e
first attempt at combined photo-z and zspec prospector models from Anya
djones1040 e825828
add new tasks to fixtures migration
djones1040 fa36936
fixed fixtures
djones1040 3463db1
added new tasks to debug utils
djones1040 e06d10e
new tasks added
djones1040 e880670
fixed training set loads (hopefully last time)
djones1040 3a5a72d
removing debugging limits
djones1040 8039912
temporarily commenting out another gas-phase metallicity key
djones1040 0d3d257
Merge branch 'main' into djones-sbi-update
manning-ncsa 8bff82f
Add __init__.py to SBI folder to define Python package
manning-ncsa 787af61
Add notes to manifest file for changed data files
manning-ncsa cbccd86
Modify workflow to include zphot chain
manning-ncsa 0673173
removing additions
djones1040 f53539c
Merge branch 'djones-sbi-update' of github.com:scimma/blast into djon…
djones1040 fe3b30d
removed gas-phase metallicity hack
djones1040 09bfbf8
removed a few of the global metallicity hacks
djones1040 1267291
merge conflict from main fixed in HostInformation
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,44 @@ | ||
| 14.095 1498.834 | ||
| 14.345 1351.754 | ||
| 14.595 1539.793 | ||
| 14.845 1354.735 | ||
| 15.095 1127.177 | ||
| 15.345 825.908 | ||
| 15.595 665.150 | ||
| 15.845 842.000 | ||
| 16.095 728.931 | ||
| 16.345 676.029 | ||
| 16.595 562.362 | ||
| 16.845 488.038 | ||
| 17.095 383.174 | ||
| 17.345 394.547 | ||
| 17.595 349.924 | ||
| 17.845 320.220 | ||
| 18.095 242.899 | ||
| 18.345 192.111 | ||
| 18.595 193.220 | ||
| 18.845 169.726 | ||
| 19.095 142.447 | ||
| 19.345 155.718 | ||
| 19.595 130.075 | ||
| 19.845 111.698 | ||
| 20.095 98.763 | ||
| 20.345 92.329 | ||
| 20.595 75.412 | ||
| 20.845 72.376 | ||
| 21.095 69.339 | ||
| 21.345 56.024 | ||
| 21.595 45.311 | ||
| 21.845 44.467 | ||
| 22.095 32.316 | ||
| 12.756 100.743 | ||
| 13.006 100.797 | ||
| 13.256 100.850 | ||
| 13.506 100.769 | ||
| 13.756 100.600 | ||
| 14.006 100.633 | ||
| 14.256 100.610 | ||
| 14.506 100.451 | ||
| 14.756 100.579 | ||
| 15.006 100.473 | ||
| 15.256 100.087 | ||
| 15.506 98.510 | ||
| 15.756 99.593 | ||
| 16.006 99.552 | ||
| 16.256 99.251 | ||
| 16.506 98.512 | ||
| 16.756 97.598 | ||
| 17.006 97.181 | ||
| 17.256 96.188 | ||
| 17.506 94.882 | ||
| 17.756 93.243 | ||
| 18.006 91.857 | ||
| 18.256 90.140 | ||
| 18.506 88.165 | ||
| 18.756 85.328 | ||
| 19.006 81.921 | ||
| 19.256 78.153 | ||
| 19.506 71.680 | ||
| 19.756 68.049 | ||
| 20.006 65.352 | ||
| 20.256 59.085 | ||
| 20.506 52.060 | ||
| 20.756 49.272 | ||
| 21.006 41.462 | ||
| 21.256 38.490 | ||
| 21.506 33.899 | ||
| 21.756 28.464 | ||
| 22.006 25.879 | ||
| 22.256 20.193 | ||
| 22.506 19.895 | ||
| 22.756 16.265 | ||
| 23.006 14.125 | ||
| 23.256 12.318 | ||
| 23.506 8.555 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,35 +1,42 @@ | ||
| 13.220 1380.660 | ||
| 13.470 1515.118 | ||
| 13.720 1440.689 | ||
| 13.970 1075.392 | ||
| 14.220 1171.863 | ||
| 14.470 1122.357 | ||
| 14.720 743.579 | ||
| 14.970 847.772 | ||
| 15.220 701.530 | ||
| 15.470 607.197 | ||
| 15.720 638.522 | ||
| 15.970 581.440 | ||
| 16.220 401.855 | ||
| 16.470 350.811 | ||
| 16.720 509.118 | ||
| 16.970 344.474 | ||
| 17.220 283.598 | ||
| 17.470 204.505 | ||
| 17.720 224.727 | ||
| 17.970 158.058 | ||
| 18.220 173.284 | ||
| 18.470 165.233 | ||
| 18.720 150.001 | ||
| 18.970 109.567 | ||
| 19.220 96.969 | ||
| 19.470 110.299 | ||
| 19.720 74.490 | ||
| 19.970 85.434 | ||
| 20.220 79.614 | ||
| 20.470 73.795 | ||
| 20.720 46.062 | ||
| 20.970 45.486 | ||
| 21.220 41.995 | ||
| 21.470 38.503 | ||
| 21.720 25.180 | ||
| 12.424 100.617 | ||
| 12.674 100.664 | ||
| 12.924 100.712 | ||
| 13.174 100.388 | ||
| 13.424 100.662 | ||
| 13.674 100.623 | ||
| 13.924 100.486 | ||
| 14.174 100.477 | ||
| 14.424 100.136 | ||
| 14.674 99.826 | ||
| 14.924 99.986 | ||
| 15.174 99.668 | ||
| 15.424 99.002 | ||
| 15.674 98.421 | ||
| 15.924 98.065 | ||
| 16.174 95.832 | ||
| 16.424 95.031 | ||
| 16.674 94.200 | ||
| 16.924 94.663 | ||
| 17.174 92.153 | ||
| 17.424 90.064 | ||
| 17.674 86.884 | ||
| 17.924 84.744 | ||
| 18.174 81.741 | ||
| 18.424 78.850 | ||
| 18.674 73.872 | ||
| 18.924 72.352 | ||
| 19.174 65.074 | ||
| 19.424 58.806 | ||
| 19.674 54.362 | ||
| 19.924 51.035 | ||
| 20.174 40.640 | ||
| 20.424 38.705 | ||
| 20.674 32.043 | ||
| 20.924 33.475 | ||
| 21.174 28.748 | ||
| 21.424 23.027 | ||
| 21.674 19.599 | ||
| 21.924 16.171 | ||
| 22.174 14.494 | ||
| 22.424 12.818 | ||
| 22.674 11.141 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What exactly is the failure mode you anticipate here? This seems too broad. Also, it looks like this block is executed upon import (which happens here), because it is not under a "if name=main" condition. Can this be done better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conversation follow-up: This redundant pickle file loading code should be refactored into a function.