Conversation
henryiii
force-pushed
the
henryiii/up/bh
branch
from
ab9396b to
fc55743
Compare
| using _atomic_type = histogram<vector_axis_variant, storage::atomic_int64>; | ||
|
|
||
| template <> | ||
| struct has_operator_rdiv_impl<_atomic_type, _atomic_type> : detect_base { | ||
| using type = mp11::mp_false; | ||
| }; |
There was a problem hiding this comment.
@HDembinski I'm having to work around the fact that count claims to have a division operator, but the implementation does not actually have one, so it reports true here then fails to compile. Same issue as the one fixed for * in boostorg/histogram#328. Though * used to work with thread_safe, and / used to be not implemented, I believe.
There was a problem hiding this comment.
Sorry again, I am getting sloppy. I am developing a fix here:
boostorg/histogram#329
Could you please use that version instead of 1.77?
There was a problem hiding this comment.
Could you sync master with develop in Boost.Histogram? I can use master, develop has been force pushed to in the past, which breaks boost-histogram if we were pointing at a commit that doesn't exist anymore and gets cleaned up.
Otherwise this works.
There was a problem hiding this comment.
Sorry, I missed that, I merged develop into master now.
henryiii
changed the title
|
After this is merged I can test boostorg/histogram#323. |
|
@HDembinski this is just waiting for the develop commit to land in master. I've started working on the accumulator branch but it will take a bit to get it to work, not ready yet. |
Sorry, it is done now. |
henryiii
force-pushed
the
henryiii/up/bh
branch
from
c329ce2 to
f27dc3c
Compare
* chore: update boost-histogram
2 participants
Adapting to the new count implementation.