Skip to content

fix: force BUILD_TESTING to inherit RUN_NINJA_TEST value #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mayeut wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: force BUILD_TESTING to inherit RUN_NINJA_TEST value #340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ jobs:
done

- name: Install SDist
run: .venv/bin/pip install --no-binary=ninja $(ls sdist/*.tar.gz)
run: .venv/bin/pip install -v --no-binary=ninja $(ls sdist/*.tar.gz)

- name: Test installed SDist
run: .venv/bin/pip check && .venv/bin/pytest ./tests
Expand Down
2 changes: 2 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ message(STATUS "")
message(STATUS " RUN_NINJA_TEST : ${RUN_NINJA_TEST}")
message(STATUS "************************************")

set(BUILD_TESTING ${RUN_NINJA_TEST} CACHE INTERNAL "")

add_subdirectory(ninja-upstream)

if(RUN_NINJA_TEST)
Expand Down