ModuleService: be smart about maps passed to run

This hack works around an issue where some script languages,
notably Jython but potentially others too, invoke the wrong run
method when called with a map. The Object... varargs method is
chosen instead of the Map method, with the map being passed as
the sole element of the object array. The code below detects
this situation, propagating the map entries into the new map.

Thanks to Robert Haase for the suggestion.

Closes scijava/scripting-jython#8.

Author: ctrueden

src/main/java/org/scijava/module/DefaultModuleService.java

@@ -412,6 +412,26 @@ private Map<String, Object> createMap(final Object[] values) {
 
 		final HashMap<String, Object> inputMap = new HashMap<>();
 
+		if (values.length == 1 && values[0] instanceof Map) {
+			// NB: This hack works around an issue where some script languages,
+			// notably Jython but potentially others too, invoke the wrong run
+			// method when called with a map. The Object... varargs method is
+			// chosen instead of the Map method, with the map being passed as
+			// the sole element of the object array. The code below detects
+			// this situation, propagating the map entries into the new map.
+			final Map<?, ?> valueMap = (Map<?, ?>) values[0];
+			for (final Object key : valueMap.keySet()) {
+				if (!(key instanceof String)) {
+					log.error("Invalid input name: " + key);
+					continue;
+				}
+				final String name = (String) key;
+				final Object value = valueMap.get(key);
+				inputMap.put(name, value);
+			}
+			return inputMap;
+		}
+
 		if (values.length % 2 != 0) {
 			log.error("Ignoring extraneous argument: " + values[values.length - 1]);
 		}