Skip to content

Commit 023a379

Browse files
committed
ModuleService: remove redundant check
As of 07e61f0, the ModuleInfo interface now extends Identifiable directly.
1 parent 225d4ba commit 023a379

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

src/main/java/org/scijava/module/DefaultModuleService.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@
4242
import java.util.concurrent.ExecutionException;
4343
import java.util.concurrent.Future;
4444

45-
import org.scijava.Identifiable;
4645
import org.scijava.MenuPath;
4746
import org.scijava.Priority;
4847
import org.scijava.convert.ConvertService;
@@ -145,8 +144,7 @@ public List<ModuleInfo> getModules() {
145144
public ModuleInfo getModuleById(final String id) {
146145
// TODO: Cache identifiers in a hash?
147146
for (final ModuleInfo info : getModules()) {
148-
if (!(info instanceof Identifiable)) continue;
149-
final String infoID = ((Identifiable) info).getIdentifier();
147+
final String infoID = info.getIdentifier();
150148
if (id.equals(infoID)) return info;
151149
}
152150
return null;

0 commit comments

Comments
 (0)