Skip to content

adapt to the move #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keewis merged 3 commits into from
Jul 13, 2025
+19 −4
Merged

adapt to the move #54

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
da1b791
upgrade python
keewis Jul 13, 2025
7885ba6
rename the action in the readme
keewis Jul 13, 2025
c780d9e
document the `assignees` setting
keewis Jul 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:

- uses: actions/setup-python@v4
with:
python-version: "3.11"
python-version: "3.12"
cache: pip

...
Expand All @@ -41,7 +41,7 @@ jobs:

...

- uses: xarray-contrib/issue-from-pytest-log@main
- uses: scientific-python/issue-from-pytest-log-action@main
if: |
failure()
&& ...
Expand Down Expand Up @@ -69,7 +69,7 @@ optional. Default: `⚠️ Nightly upstream-dev CI failed ⚠️`
In case you don't like the default title for new issues, this setting can be used to set a different one:

```yaml
- uses: xarray-contrib/issue-from-pytest-log@v1
- uses: scientific-python/issue-from-pytest-log-action@main
Copy link
Member

@bsipocz bsipocz Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's correct to recommend using the main for any actions, let alone one that opens issues.

Can we change back the versions to preferably recommend a hash, or at worst a version alias?

(hash: while this is not a release action and thus it's not critical; for consistency the recommendation is to pin to a hash: scientific-python/specs#392 (comment). Dependabot will deal with it just fine.

Copy link
Contributor Author

@keewis keewis Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, see #55

Copy link
Member

@bsipocz bsipocz Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

with:
log-path: pytest-log.jsonl
issue-title: "Nightly CI failed"
Expand All @@ -84,8 +84,23 @@ optional. Default: `CI`
The label to set on the new issue.

```yaml
- uses: xarray-contrib/issue-from-pytest-log@v1
- uses: scientific-python/issue-from-pytest-log-action@main
with:
log-path: pytest-log.jsonl
issue-label: "CI"
```

### assignees

optional

Any assignees to set on the new issue:

```yaml
- uses: scientific-python/issue-from-pytest-log-action@main
with:
log-path: pytest-log.jsonl
assignees: ["user1", "user2"]
```

Note that assignees must have the commit bit on the repository.