Skip to content

Conversation

@agriyakhetarpal
Copy link
Member

@agriyakhetarpal agriyakhetarpal commented Dec 4, 2025

Note

This PR is a draft, and its description is a stub. I'll update it soon!

Closes #83

TODO:

Release note

For maintainers and optionally contributors, please refer to the instructions on how to document this PR for the release notes.

By default, hide pull requests that are authored by users / bots given in
the config field `ignored_user_logins. This behavior can be overridden by
explicitly specifying the new config field `ignore_prs_by_username`.

@agriyakhetarpal agriyakhetarpal changed the title Ignore PRs by bots in the generated changelist Ignore PRs by specified usernames in the generated changelist Dec 4, 2025
@stefanv
Copy link
Member

stefanv commented Dec 4, 2025

I'd really appreciate having this feature; trying to release yaml2ics now, and the changelog is filled with "Bump x to version y"

@stefanv stefanv added the type: Enhancement New feature or request label Dec 4, 2025
@stefanv
Copy link
Member

stefanv commented Dec 4, 2025

I can confirm that this PR did the trick :)

lagru added 3 commits December 4, 2025 14:51
This allows users to configure ignored contributors and which PRs are
ingnored by users independently. At the same time most users for which
these two fields may look the same don't have to repeat themselves.
@agriyakhetarpal
Copy link
Member Author

Ah, I was going to push changes just now :( thanks for taking it further up anyway, @lagru!

lagru added 2 commits December 4, 2025 15:11
Dereferencing can only be done once both fields have been loaded which
may happen only at this stage when adding defaults.
@lagru
Copy link
Member

lagru commented Dec 4, 2025

@agriyakhetarpal sorry for my bad timing! I hope I didn't waste too much of your time here and that you didn't feel like I stepped on your toes. 🙏 Since there was some demand for it, I thought it quickest to finish this up myself. I'll check-in with you next time!

@lagru
Copy link
Member

lagru commented Dec 4, 2025

@stefanv I've added a new config field ignore_prs_by_username that defaults to ignored_user_logins. I confirmed that hides the "Bump" PRs in https://github.com/scientific-python/lazy-loader/releases/tag/v0.4 when regenerating the notes with

changelist scientific-python/lazy-loader v0.3 v0.4

I'll wait a bit in case @stefanv wants to test this again or in case @agriyakhetarpal has feedback or wants to push more changes.

@lagru lagru marked this pull request as ready for review December 4, 2025 15:22
@lagru lagru merged commit 4e4a506 into scientific-python:main Dec 5, 2025
6 checks passed
@lagru lagru added this to the 0.6 milestone Dec 5, 2025
@stefanv
Copy link
Member

stefanv commented Dec 6, 2025

Thanks so much, @lagru and @agriyakhetarpal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow ignoring PRs from bots

3 participants