-
Notifications
You must be signed in to change notification settings - Fork 5
Ignore PRs by specified usernames in the generated changelist #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore PRs by specified usernames in the generated changelist #85
Conversation
|
I'd really appreciate having this feature; trying to release yaml2ics now, and the changelog is filled with "Bump x to version y" |
|
I can confirm that this PR did the trick :) |
This allows users to configure ignored contributors and which PRs are ingnored by users independently. At the same time most users for which these two fields may look the same don't have to repeat themselves.
|
Ah, I was going to push changes just now :( thanks for taking it further up anyway, @lagru! |
Dereferencing can only be done once both fields have been loaded which may happen only at this stage when adding defaults.
|
@agriyakhetarpal sorry for my bad timing! I hope I didn't waste too much of your time here and that you didn't feel like I stepped on your toes. 🙏 Since there was some demand for it, I thought it quickest to finish this up myself. I'll check-in with you next time! |
|
@stefanv I've added a new config field I'll wait a bit in case @stefanv wants to test this again or in case @agriyakhetarpal has feedback or wants to push more changes. |
|
Thanks so much, @lagru and @agriyakhetarpal! |
Note
This PR is a draft, and its description is a stub. I'll update it soon!
Closes #83
TODO:
Release note
For maintainers and optionally contributors, please refer to the instructions on how to document this PR for the release notes.