[Snyk] Fix for 5 vulnerabilities #77
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following vulnerabilities are fixed by pinning transitive dependencies: - https://snyk.io/vuln/SNYK-PYTHON-DJANGO-14157807 - https://snyk.io/vuln/SNYK-PYTHON-DJANGO-14157810 - https://snyk.io/vuln/SNYK-PYTHON-SQLPARSE-14157217 - https://snyk.io/vuln/SNYK-PYTHON-URLLIB3-14192442 - https://snyk.io/vuln/SNYK-PYTHON-URLLIB3-14192443
There was a problem hiding this comment.
Pull request overview
This PR upgrades several Python dependencies to address 5 security vulnerabilities identified by Snyk, including critical updates to Django, sqlparse, and the addition of urllib3.
Key changes:
- Django upgraded from 3.2.6 to 4.2.27 (major version jump from 3.x to 4.x)
- sqlparse upgraded from 0.4.1 to 0.5.4
- urllib3 >=2.6.0 added as an explicit dependency to resolve transitive vulnerabilities
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| -e git+https://github.com/scieloorg/opac_schema.git@v2.62#egg=opac_schema | ||
| -e git+https://github.com/scieloorg/dsm.git@v0.1.1#egg=dsm | ||
| -e git+https://github.com/scieloorg/scielo_v3_manager.git@0.6#egg=scielo_v3_manager | ||
| urllib3>=2.6.0 # not directly required, pinned by Snyk to avoid a vulnerability |
There was a problem hiding this comment.
Using >=2.6.0 for urllib3 allows any future version to be installed, which could introduce breaking changes or new vulnerabilities. For reproducible builds and better dependency management, consider pinning to a specific version or using a constraint like >=2.6.0,<3.0.0.
Example: urllib3>=2.6.0,<3.0.0 # not directly required, pinned by Snyk to avoid a vulnerability
Suggested change
| urllib3>=2.6.0 # not directly required, pinned by Snyk to avoid a vulnerability | |
| urllib3>=2.6.0,<3.0.0 # not directly required, pinned by Snyk to avoid a vulnerability |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snyk has created this PR to fix 5 vulnerabilities in the pip dependencies of this project.
Snyk changed the following file(s):
app/requirements.txtImportant
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 SQL Injection
🦉 Allocation of Resources Without Limits or Throttling