Fix crash in get_acron_issueid_fname_without_extension when FILE_REGEX doesn't match#323
Draft
Fix crash in get_acron_issueid_fname_without_extension when FILE_REGEX doesn't match#323
Conversation
…ithout_extension Co-authored-by: robertatakenaka <505143+robertatakenaka@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix error in load_languages process
Fix crash in get_acron_issueid_fname_without_extension when FILE_REGEX doesn't match
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
O que esse PR faz?
Corrige dois bugs encadeados em
get_acron_issueid_fname_without_extensionque causavam crash do scriptload_languages:AttributeError:FILE_REGEX.search()retornaNonepara paths como./argos/aceeed/n21/2545-8299-ACEEED-21-137.xml, e.group()é chamado sobreNoneUnboundLocalError: o blocoexceptreferenciafile_idque nunca foi atribuído (erro ocorre antes da atribuição)logger.errorrecebia(file_path, file_id)como tupla única em vez de argumentos separadosexcept:substituído porexcept Exception:O script agora loga o erro e continua processando os demais documentos.
Onde a revisão poderia começar?
processing/load_languages.py, funçãoget_acron_issueid_fname_without_extension(~linha 93).Como este poderia ser testado manualmente?
Teste unitário adicionado:
test_get_acron_issueid_fname_without_extension_no_match.Algum cenário de contexto que queira dar?
O regex
FILE_REGEX = re.compile(r'serial.*.htm|.*.xml|.*.pdf')não corresponde a todos os file paths possíveis. Quando o match falha, a função deve retornarNonegraciosamente — o chamador (fulltexts) já trata esse caso na linha 315-317.Screenshots
N/A
Quais são tickets relevantes?
Referências
N/A
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.