feat: Add global ambient light to PBR shader#219
Merged
Conversation
Add an ambient_color field (Vec4: RGB + intensity) to LightingDescriptor, allowing users to set a flat ambient light term via Stage::set_ambient_color. The ambient contribution is modulated by surface albedo and ambient occlusion, and is additive with the existing IBL and analytical light contributions. Defaults to zero for full backward compatibility. Co-authored-by: Claude <noreply@anthropic.com>
schell
force-pushed
the
feat/ambient-light
branch
from
cacbffa to
e48ca61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an ambient_color field (Vec4: RGB + intensity) to LightingDescriptor, allowing users to set a flat ambient light term via Stage::set_ambient_color. The ambient contribution is modulated by surface albedo and ambient occlusion, and is additive with the existing IBL and analytical light contributions. Defaults to zero for full backward compatibility.
These changes were made in part by claude code (Opus 4.6). The session transcript is attached.
session-ambient-light.md