Skip to content

feat(schema): add acknowledgement field to BOM operations#6

Open
isasmendiagus wants to merge 1 commit intomainfrom
chore/SP-4077/add-acknowledgement-field
Open

feat(schema): add acknowledgement field to BOM operations#6
isasmendiagus wants to merge 1 commit intomainfrom
chore/SP-4077/add-acknowledgement-field

Conversation

@isasmendiagus
Copy link
Contributor

@isasmendiagus isasmendiagus commented Mar 19, 2026

Summary by CodeRabbit

  • New Features
    • Added optional acknowledgement field to BOM rule configurations for include, remove, and replace actions. Acknowledgements will be included in generated SBOM output, allowing for better documentation and traceability of component handling decisions.

@coderabbitai
Copy link

coderabbitai bot commented Mar 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 73de6902-6bec-4793-a3f2-edca52a7a7ba

📥 Commits

Reviewing files that changed from the base of the PR and between 6891ed6 and 7b87382.

📒 Files selected for processing (1)
  • scanoss-settings-schema.json

📝 Walkthrough

Walkthrough

This PR extends the BOM rule item schema in scanoss-settings-schema.json by adding an optional acknowledgement string field to include, remove, and replace rule definitions. Example objects are updated accordingly to reflect the new field.

Changes

Cohort / File(s) Summary
BOM Schema Enhancement
scanoss-settings-schema.json
Added optional acknowledgement string field to BOM rule item schemas for bom.include[], bom.remove[], and bom.replace[], with corresponding example value updates.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Hop, hop! A field blooms anew,
Acknowledgement shines in schema's view,
BOM rules grow with grace so bright,
JSON enriched, everything's right! 📋✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding an acknowledgement field to BOM operations (include, remove, and replace). It is concise, specific, and directly related to the primary modification in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/SP-4077/add-acknowledgement-field
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant