feat: add text overflow detection to TextFrame#1114
Open
saggl wants to merge 1 commit intoscanny:masterfrom
Open
feat: add text overflow detection to TextFrame#1114saggl wants to merge 1 commit intoscanny:masterfrom
saggl wants to merge 1 commit intoscanny:masterfrom
Conversation
Add new methods to detect and analyze text overflow before it occurs: - TextFrame.will_overflow(): Simple boolean check for overflow - TextFrame.overflow_info(): Detailed overflow metrics with OverflowInfo dataclass - TextFitter.will_fit(): Core overflow detection logic - TextFitter.measure_text_height(): Calculate required text height - TextFitter.calculate_overflow_metrics(): Detailed overflow analysis The OverflowInfo dataclass provides: - will_overflow: Boolean indicator - required_height/available_height: Size metrics - overflow_height/overflow_percentage: Overflow amounts - estimated_lines: Line count estimate - fits_at_font_size: Recommended font size to fit This enables proactive content validation to prevent text from being cut off at the bottom of text frames, addressing the issue where users don't know content will overflow until they open the presentation. Includes comprehensive unit tests, feature tests, and examples. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new methods to detect and analyze text overflow before it occurs:
The OverflowInfo dataclass provides:
This enables proactive content validation to prevent text from being cut off at the bottom of text frames, addressing the issue where users don't know content will overflow until they open the presentation.
Includes comprehensive unit tests, feature tests, and examples.