Return user metadata in GetObjectAttributes API by maeldonn · Pull Request #6070 · scality/cloudserver

maeldonn · 2026-02-04T07:37:07Z

codecov · 2026-02-04T10:06:47Z

Codecov Report

❌ Patch coverage is 90.19608% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.20%. Comparing base (e118699) to head (595b908).
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
lib/api/bucketGet.js	61.53%	5 Missing ⚠️

Additional details and impacted files

Files with missing lines	Coverage Δ
...i/apiUtils/authorization/prepareRequestContexts.js	`95.58% <100.00%> (+0.23%)`	⬆️
lib/api/apiUtils/object/extractUserMetadata.js	`100.00% <100.00%> (ø)`
lib/api/apiUtils/object/parseAttributesHeader.js	`100.00% <100.00%> (ø)`
lib/api/metadataSearch.js	`76.38% <100.00%> (ø)`
lib/api/objectGetAttributes.js	`97.29% <100.00%> (+0.28%)`	⬆️
lib/routes/veeam/list.js	`97.50% <ø> (ø)`
lib/utilities/serverAccessLogger.js	`81.85% <ø> (ø)`
lib/api/bucketGet.js	`92.81% <61.53%> (+0.26%)`	⬆️

@@                             Coverage Diff                              @@
##           feature/CLDSRV-817/get-object-attributes    #6070      +/-   ##
============================================================================
+ Coverage                                     84.17%   84.20%   +0.03%     
============================================================================
  Files                                           206      207       +1     
  Lines                                         13233    13253      +20     
============================================================================
+ Hits                                          11139    11160      +21     
+ Misses                                         2094     2093       -1

Flag	Coverage Δ
file-ft-tests	`67.90% <82.35%> (+0.11%)`	⬆️
kmip-ft-tests	`28.12% <13.72%> (-0.01%)`	⬇️
mongo-v0-ft-tests	`69.11% <84.31%> (+0.11%)`	⬆️
mongo-v1-ft-tests	`69.22% <84.31%> (+0.11%)`	⬆️
multiple-backend	`35.17% <39.21%> (+0.04%)`	⬆️
sur-tests	`36.48% <23.52%> (+0.83%)`	⬆️
sur-tests-inflights	`37.52% <23.52%> (+0.01%)`	⬆️
unit	`69.89% <88.23%> (+0.05%)`	⬆️
utapi-v2-tests	`34.43% <39.21%> (+0.04%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lib/api/apiUtils/authorization/prepareRequestContexts.js

lib/api/apiUtils/object/parseAttributesHeader.js

SylvainSenechal · 2026-02-10T11:16:06Z

lib/api/apiUtils/object/parseAttributesHeader.js

+    headers[headerName]
+      ?.split(',')
+      .map(attr => attr.trim())
+      .map(attr => (supportedAttributes.has(attr) ? attr : attr.toLowerCase())) ?? [];


wait so it means even if the attribute is not in supportedAttribute, it will be returned as lower cased ?
Shouldn't this be a filter instead ?

I mean, ok I guess the overall function works because later there is the attributes.some() and has() thing, but could it be clearer

Anyways, maybe the funciton is good enough as it is, but if you're able to make it a bit clearer it's nice, cause it's doing multiple thing that aren't completely obvious from the function name, it looks like it's gonna do some generic parsing, then ends up doing lowercasing and having a special case for x-amz-meta. Maybe renaming function name and intermediates variables help

If it's not a supported attribute:

It's user metadata so it's ok

It's something else -> will throw an exception

this seems uselessly innefficient: we traverse the list 3 times to do the same thing...

trim() can be done in the same iteration, no need to the extra strings/list allocation

isn't user metadata already mandated (by spec) to be lower case? do we do the same lower case conversion in other APIs? if not, not need to be more accommodating here

if an attribute is in the supportedAttributes, there is no point making another check for the prefix (and rechecking later it is a supported attribute, if there is no prefix)

Suggested change

.map(attr => (supportedAttributes.has(attr) ? attr : attr.toLowerCase())) ?? [];

const attributes =

headers[headerName]?.split(',').map(attr => {

const res = attr.trim())

if (!supportedAttributes.has(res) && !res.startsWith('x-amz-meta-')) {

throw errorInstances.InvalidArgument.customizeDescription('Invalid attribute name specified.');

}

return res;

});

lib/api/objectGetAttributes.js

tests/functional/aws-node-sdk/test/object/objectGetAttributes.js

SylvainSenechal

some comments to address, 2 tests to add

francoisferrand · 2026-02-11T08:52:32Z

lib/api/apiUtils/object/parseAttributesHeader.js

+    headers[headerName]
+      ?.split(',')
+      .map(attr => attr.trim())
+      .map(attr => (supportedAttributes.has(attr) ? attr : attr.toLowerCase())) ?? [];


this seems uselessly innefficient: we traverse the list 3 times to do the same thing...

trim() can be done in the same iteration, no need to the extra strings/list allocation

isn't user metadata already mandated (by spec) to be lower case? do we do the same lower case conversion in other APIs? if not, not need to be more accommodating here

if an attribute is in the supportedAttributes, there is no point making another check for the prefix (and rechecking later it is a supported attribute, if there is no prefix)

Suggested change

.map(attr => (supportedAttributes.has(attr) ? attr : attr.toLowerCase())) ?? [];

const attributes =

headers[headerName]?.split(',').map(attr => {

const res = attr.trim())

if (!supportedAttributes.has(res) && !res.startsWith('x-amz-meta-')) {

throw errorInstances.InvalidArgument.customizeDescription('Invalid attribute name specified.');

}

return res;

});

francoisferrand · 2026-02-11T08:53:45Z

lib/api/bucketGet.js

+    let optionalAttributes;
+    try {
+        const headerName = 'x-amz-optional-object-attributes';
+        optionalAttributes = parseAttributesHeaders(request.headers, headerName, new Set(['RestoreStatus']));


The Set should not be allocated on every call, should be a constant

francoisferrand · 2026-02-11T08:54:21Z

lib/api/objectGetAttributes.js

+ * @param {string[]} attributes - requested attributes
+ * @returns {object} - object containing requested user metadata key-value pairs
+ */
+function extractUserMetadata(objMD, attributes) {


there is already this logic in ListObjectv2, must be factorized...

francoisferrand · 2026-02-11T08:56:10Z

lib/api/objectGetAttributes.js

  }

-  const attributes = parseAttributesHeaders(headers);
+  const attributes = parseAttributesHeaders(headers, 'x-amz-object-attributes', supportedGetObjectAttributes, true);


this true here makes it hard to understand what is happening, and it can just as well be done here (it does not add any value to have a conditional behavior inside the parseAttributesHeaders function):

Suggested change

const attributes = parseAttributesHeaders(headers, 'x-amz-object-attributes', supportedGetObjectAttributes, true);

const attributes = parseAttributesHeaders(headers, 'x-amz-object-attributes', supportedGetObjectAttributes);

if (attributes.length === 0) {

throw ....

}

Issue: CLDSRV-844

maeldonn force-pushed the feature/CLDSRV-844/user-metadata branch from 2e7333e to 2b69771 Compare February 4, 2026 10:04

maeldonn force-pushed the feature/CLDSRV-844/user-metadata branch 4 times, most recently from 95b17ef to ab4f29a Compare February 4, 2026 14:38

maeldonn force-pushed the feature/CLDSRV-817/get-object-attributes branch from 64cd8a1 to 4a72a6d Compare February 4, 2026 14:41

maeldonn force-pushed the feature/CLDSRV-844/user-metadata branch from ab4f29a to fc3441c Compare February 4, 2026 14:41

maeldonn force-pushed the feature/CLDSRV-817/get-object-attributes branch from 4a72a6d to 92bd9be Compare February 4, 2026 14:47

maeldonn force-pushed the feature/CLDSRV-844/user-metadata branch 2 times, most recently from 4b757aa to 78dd47a Compare February 4, 2026 15:50

maeldonn requested review from a team, SylvainSenechal and benzekrimaha February 4, 2026 16:35

maeldonn force-pushed the feature/CLDSRV-844/user-metadata branch from 78dd47a to 1a3d966 Compare February 9, 2026 14:41

maeldonn requested review from DarkIsDude, delthas and francoisferrand February 9, 2026 19:14

DarkIsDude removed their request for review February 10, 2026 09:44

SylvainSenechal reviewed Feb 10, 2026

View reviewed changes

lib/api/apiUtils/authorization/prepareRequestContexts.js Show resolved Hide resolved

SylvainSenechal reviewed Feb 10, 2026

View reviewed changes

lib/api/apiUtils/object/parseAttributesHeader.js Show resolved Hide resolved

SylvainSenechal reviewed Feb 10, 2026

View reviewed changes

lib/api/objectGetAttributes.js Outdated Show resolved Hide resolved

SylvainSenechal reviewed Feb 10, 2026

View reviewed changes

tests/functional/aws-node-sdk/test/object/objectGetAttributes.js Outdated Show resolved Hide resolved

SylvainSenechal requested changes Feb 10, 2026

View reviewed changes

maeldonn requested a review from SylvainSenechal February 10, 2026 17:27

SylvainSenechal approved these changes Feb 10, 2026

View reviewed changes

francoisferrand requested changes Feb 11, 2026

View reviewed changes

maeldonn force-pushed the feature/CLDSRV-817/get-object-attributes branch from 4868753 to c762cd8 Compare February 12, 2026 10:11

maeldonn force-pushed the feature/CLDSRV-844/user-metadata branch from e040894 to 63d9d12 Compare February 12, 2026 13:59

maeldonn force-pushed the feature/CLDSRV-817/get-object-attributes branch from c762cd8 to bef8034 Compare February 12, 2026 15:00

maeldonn force-pushed the feature/CLDSRV-844/user-metadata branch 2 times, most recently from 704c58d to 34f10d2 Compare February 12, 2026 17:07

maeldonn requested a review from francoisferrand February 12, 2026 20:42

maeldonn force-pushed the feature/CLDSRV-817/get-object-attributes branch from 3ebd2ab to e118699 Compare February 13, 2026 14:21

maeldonn added 8 commits February 13, 2026 15:22

Support user metadata

52ee394

Issue: CLDSRV-844

Add a new permission to get user metadata

7f7f2d3

Issue: CLDSRV-844

Parse optional attributes header with utility function

3473cba

Handle rights for GetObjectAttributes

062640a

Issue: CLDSRV-844

fixup! Add a new permission to get user metadata

ebe76d7

fixup! Support user metadata

9c23642

fixup! Handle rights for GetObjectAttributes

86e9d73

fixup! Parse optional attributes header with utility function

74c8a30

maeldonn force-pushed the feature/CLDSRV-844/user-metadata branch from 34f10d2 to 74c8a30 Compare February 13, 2026 14:22

fixup! Parse optional attributes header with utility function

15e0eb6

delthas removed their request for review February 16, 2026 10:08

Add objectGetAttributes in server access logs

595b908

Issue: CLDSRV-844

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Return user metadata in GetObjectAttributes API#6070

Return user metadata in GetObjectAttributes API#6070
maeldonn wants to merge 10 commits intofeature/CLDSRV-817/get-object-attributesfrom
feature/CLDSRV-844/user-metadata

maeldonn commented Feb 4, 2026

Uh oh!

codecov bot commented Feb 4, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

SylvainSenechal Feb 10, 2026

Uh oh!

SylvainSenechal Feb 10, 2026

Uh oh!

maeldonn Feb 10, 2026 •

edited

Loading

Uh oh!

francoisferrand Feb 11, 2026

Uh oh!

Uh oh!

Uh oh!

SylvainSenechal left a comment

Uh oh!

francoisferrand Feb 11, 2026

Uh oh!

francoisferrand Feb 11, 2026

Uh oh!

francoisferrand Feb 11, 2026

Uh oh!

francoisferrand Feb 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

-      .map(attr => (supportedAttributes.has(attr) ? attr : attr.toLowerCase())) ?? [];
+  const attributes =
+    headers[headerName]?.split(',').map(attr => {
+		const res = attr.trim())
+		if (!supportedAttributes.has(res) && !res.startsWith('x-amz-meta-')) {
+            throw errorInstances.InvalidArgument.customizeDescription('Invalid attribute name specified.');
+        }
+        return res;
+    });

-  const attributes = parseAttributesHeaders(headers, 'x-amz-object-attributes', supportedGetObjectAttributes, true);
+  const attributes = parseAttributesHeaders(headers, 'x-amz-object-attributes', supportedGetObjectAttributes);
+  if (attributes.length === 0) {
+      throw ....
+  }

Conversation

maeldonn commented Feb 4, 2026

Uh oh!

codecov bot commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

SylvainSenechal Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

SylvainSenechal Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

maeldonn Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

francoisferrand Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

SylvainSenechal left a comment

Choose a reason for hiding this comment

Uh oh!

francoisferrand Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

francoisferrand Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

francoisferrand Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

francoisferrand Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Feb 4, 2026 •

edited

Loading

maeldonn Feb 10, 2026 •

edited

Loading