(PTFE-2638) Consider a skipped conclusion as success#256
(PTFE-2638) Consider a skipped conclusion as success#256matthiasL-scality merged 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #256 +/- ##
=======================================
Coverage 89.02% 89.03%
=======================================
Files 75 75
Lines 10053 10060 +7
=======================================
+ Hits 8950 8957 +7
Misses 1103 1103
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
charlesprost
left a comment
There was a problem hiding this comment.
Let's make sure @tcarmet approves it first
tcarmet
left a comment
There was a problem hiding this comment.
The runtime code LGTM, I think that's it. But I'm having some trouble with the test scenario. It would help to split the problem and create a new particular test with the scenario we are trying to fix.
41f5e69 to
8765097
Compare
8765097 to
a5258a8
Compare
charlesprost
left a comment
There was a problem hiding this comment.
Let's make sure @tcarmet approves it first
tcarmet
left a comment
There was a problem hiding this comment.
awesome, thank you for the changes and the extra test.
Purpose
Added status skipped for considering workflow skipped. If a workflow is skipped it will be consider has a success