Skip to content

BB-750: Integrate shared prettier#2742

Open
benzekrimaha wants to merge 3 commits into
development/9.5from
improvement/BB-750-integrate-shared-prettier
Open

BB-750: Integrate shared prettier#2742
benzekrimaha wants to merge 3 commits into
development/9.5from
improvement/BB-750-integrate-shared-prettier

Conversation

@benzekrimaha
Copy link
Copy Markdown
Contributor

Issue: BB-750

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented May 22, 2026

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@benzekrimaha benzekrimaha marked this pull request as ready for review May 22, 2026 15:49
@scality scality deleted a comment from bert-e May 22, 2026
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented May 22, 2026

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@claude
Copy link
Copy Markdown

claude Bot commented May 22, 2026

LGTM — Clean integration of shared Prettier config. CI workflow correctly uses merge-base for incremental checks, BASE_REF is safely passed via env var (not inline expression), git deps remain pinned to tags, and the .prettierignore covers the right directories.

Review by Claude Code

Comment thread package.json
"bh_test": "mocha --recursive tests/behavior --exit",
"lint": "eslint $(git ls-files '*.js')",
"lint_md": "mdlint $(git ls-files '[^bucket-scanner/]*.md')",
"prettier": "prettier",
Copy link
Copy Markdown
Contributor Author

@benzekrimaha benzekrimaha May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for package.json: most of this diff is formatting-only from applying the shared Prettier config, similar to what was done in Arsenal.

The functional changes are limited to:

  • bumping eslint-config-scality to the Guidelines version that ships the shared Prettier config
  • adding prettier
  • adding the prettier / prettier:diff scripts

The indentation churn is expected so package.json is aligned with the new Prettier baseline. Reviewing with “Hide whitespace” should make the actual dependency/script changes easier to see.

@benzekrimaha benzekrimaha force-pushed the improvement/BB-750-integrate-shared-prettier branch from 5e463a9 to 3a05a78 Compare May 26, 2026 08:13
@codecov
Copy link
Copy Markdown

codecov Bot commented May 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.62%. Comparing base (8e2f11a) to head (3a05a78).

Additional details and impacted files

Impacted file tree graph
see 3 files with indirect coverage changes

Components Coverage Δ
Bucket Notification 80.22% <ø> (ø)
Core Library 80.74% <ø> (-0.63%) ⬇️
Ingestion 71.24% <ø> (ø)
Lifecycle 79.06% <ø> (ø)
Oplog Populator 85.83% <ø> (ø)
Replication 59.75% <ø> (-0.04%) ⬇️
Bucket Scanner 85.76% <ø> (ø)
@@                 Coverage Diff                 @@
##           development/9.5    #2742      +/-   ##
===================================================
- Coverage            74.89%   74.62%   -0.27%     
===================================================
  Files                  199      199              
  Lines                13648    13648              
===================================================
- Hits                 10221    10185      -36     
- Misses                3417     3453      +36     
  Partials                10       10              
Flag Coverage Δ
api:retry 9.13% <ø> (ø)
api:routes 8.95% <ø> (ø)
bucket-scanner 85.76% <ø> (ø)
ft_test:queuepopulator 9.08% <ø> (-1.89%) ⬇️
ingestion 12.57% <ø> (ø)
lib 7.74% <ø> (ø)
lifecycle 18.98% <ø> (-0.01%) ⬇️
notification 1.02% <ø> (ø)
oplogPopulator 0.14% <ø> (ø)
replication 18.71% <ø> (ø)
unit 51.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@claude
Copy link
Copy Markdown

claude Bot commented May 26, 2026

LGTM — Clean integration of shared Prettier tooling. CI workflow has proper permissions (contents: read), env-var-based BASE_REF usage avoids script injection, eslint-config-scality stays pinned to a tag (#8.3.2), and the .prettierignore covers the right directories.

Review by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants