BB-750: Integrate shared prettier#2742
Conversation
Hello benzekrimaha,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
|
LGTM — Clean integration of shared Prettier config. CI workflow correctly uses merge-base for incremental checks, BASE_REF is safely passed via env var (not inline expression), git deps remain pinned to tags, and the .prettierignore covers the right directories. |
| "bh_test": "mocha --recursive tests/behavior --exit", | ||
| "lint": "eslint $(git ls-files '*.js')", | ||
| "lint_md": "mdlint $(git ls-files '[^bucket-scanner/]*.md')", | ||
| "prettier": "prettier", |
There was a problem hiding this comment.
Note for package.json: most of this diff is formatting-only from applying the shared Prettier config, similar to what was done in Arsenal.
The functional changes are limited to:
- bumping
eslint-config-scalityto the Guidelines version that ships the shared Prettier config - adding
prettier - adding the
prettier/prettier:diffscripts
The indentation churn is expected so package.json is aligned with the new Prettier baseline. Reviewing with “Hide whitespace” should make the actual dependency/script changes easier to see.
5e463a9 to
3a05a78
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
@@ Coverage Diff @@
## development/9.5 #2742 +/- ##
===================================================
- Coverage 74.89% 74.62% -0.27%
===================================================
Files 199 199
Lines 13648 13648
===================================================
- Hits 10221 10185 -36
- Misses 3417 3453 +36
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
LGTM — Clean integration of shared Prettier tooling. CI workflow has proper permissions (contents: read), env-var-based BASE_REF usage avoids script injection, eslint-config-scality stays pinned to a tag (#8.3.2), and the .prettierignore covers the right directories. |
Issue: BB-750