Skip to content

fix unhandler error -172 on entry committable causing the server to crash#2731

Open
SylvainSenechal wants to merge 1 commit intodevelopment/9.4from
bugfix/BB-758
Open

fix unhandler error -172 on entry committable causing the server to crash#2731
SylvainSenechal wants to merge 1 commit intodevelopment/9.4from
bugfix/BB-758

Conversation

@SylvainSenechal
Copy link
Copy Markdown
Contributor

Issue: BB-758

Seen in zenko ci :
image

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 8, 2026

Hello sylvainsenechal,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 8, 2026

Incorrect fix version

The Fix Version/s in issue BB-758 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.4.0

Please check the Fix Version/s of BB-758, or the target
branch of this pull request.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.53%. Comparing base (9c21188) to head (f308a2a).

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/BackbeatConsumer.js 93.88% <100.00%> (+0.04%) ⬆️

... and 3 files with indirect coverage changes

Components Coverage Δ
Bucket Notification 80.37% <ø> (ø)
Core Library 80.72% <100.00%> (-0.42%) ⬇️
Ingestion 70.53% <ø> (-0.62%) ⬇️
Lifecycle 79.01% <ø> (ø)
Oplog Populator 85.83% <ø> (ø)
Replication 59.65% <ø> (ø)
Bucket Scanner 85.76% <ø> (ø)
@@                 Coverage Diff                 @@
##           development/9.4    #2731      +/-   ##
===================================================
- Coverage            74.75%   74.53%   -0.23%     
===================================================
  Files                  200      200              
  Lines                13610    13613       +3     
===================================================
- Hits                 10174    10146      -28     
- Misses                3426     3457      +31     
  Partials                10       10              
Flag Coverage Δ
api:retry 9.14% <0.00%> (-0.01%) ⬇️
api:routes 8.95% <0.00%> (-0.01%) ⬇️
bucket-scanner 85.76% <ø> (ø)
ft_test:queuepopulator 10.01% <0.00%> (-0.57%) ⬇️
ingestion 12.49% <0.00%> (-0.07%) ⬇️
lib 7.62% <60.00%> (+<0.01%) ⬆️
lifecycle 18.84% <60.00%> (-0.01%) ⬇️
notification 1.02% <0.00%> (-0.01%) ⬇️
oplogPopulator 0.14% <0.00%> (-0.01%) ⬇️
replication 18.49% <60.00%> (+<0.01%) ⬆️
unit 51.16% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@claude
Copy link
Copy Markdown

claude bot commented Apr 8, 2026

LGTM

Review by Claude Code

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 8, 2026

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@SylvainSenechal SylvainSenechal requested review from a team, benzekrimaha and maeldonn April 8, 2026 18:51
@SylvainSenechal SylvainSenechal marked this pull request as ready for review April 8, 2026 18:51
try {
this._consumer.offsetsStore([{ topic, partition, offset: committableOffset }]);
} catch (e) {
// ERR__STATE (-172) means the consumer is not in a valid state
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this stuff seems to happen on rebalance or weird kafka status.

  • Before, the pod would crash, the offset wouldn't be commited, and another one pod would reconsume and re process it
  • Now : the pod doesn't crash, but the offset is still not commited. and reconsumed later by another pod, or maybe the same pod since now it doesn't crash anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants