fix unhandler error -172 on entry committable causing the server to crash#2731
Open
SylvainSenechal wants to merge 1 commit intodevelopment/9.4from
Open
fix unhandler error -172 on entry committable causing the server to crash#2731SylvainSenechal wants to merge 1 commit intodevelopment/9.4from
SylvainSenechal wants to merge 1 commit intodevelopment/9.4from
Conversation
Contributor
Hello sylvainsenechal,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
... and 3 files with indirect coverage changes
@@ Coverage Diff @@
## development/9.4 #2731 +/- ##
===================================================
- Coverage 74.75% 74.53% -0.23%
===================================================
Files 200 200
Lines 13610 13613 +3
===================================================
- Hits 10174 10146 -28
- Misses 3426 3457 +31
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
LGTM |
Contributor
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
SylvainSenechal
commented
Apr 8, 2026
| try { | ||
| this._consumer.offsetsStore([{ topic, partition, offset: committableOffset }]); | ||
| } catch (e) { | ||
| // ERR__STATE (-172) means the consumer is not in a valid state |
Contributor
Author
There was a problem hiding this comment.
So this stuff seems to happen on rebalance or weird kafka status.
- Before, the pod would crash, the offset wouldn't be commited, and another one pod would reconsume and re process it
- Now : the pod doesn't crash, but the offset is still not commited. and reconsumed later by another pod, or maybe the same pod since now it doesn't crash anymore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: BB-758
Seen in zenko ci :
