BB-295 - bootstrap ts compilation by jbertran · Pull Request #2337 · scality/backbeat

jbertran · 2022-10-14T14:17:57Z

Outcome so far:

TypeScript is integrated in the build environment, and compiles to the dist folder
Jest is configured to use the mixed sources with on-the-fly compilation, and runs all tests that were run with mocha
Some test scripts pass:
- unit
- routes
- retry

Remaining work is simply ensuring all other test suites pass (bonus: make them separate parallel steps in the build process, such that the work doesn’t need to be sequential).

Zenko Build: https://github.com/scality/Zenko/actions/runs/3822509132

bert-e · 2022-10-14T14:18:00Z

Hello jbertran,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

bert-e · 2022-10-14T14:18:04Z

Incorrect fix version

The Fix Version/s in issue BB-295 contains:

8.3.20

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

8.5.0

Please check the Fix Version/s of BB-295, or the target
branch of this pull request.

jbertran · 2022-10-14T15:05:40Z

/approve

jbertran · 2022-10-14T15:05:45Z

/wait

Dockerfile

tsconfig.json

package.json

Dockerfile

rachedbenmustapha · 2023-02-16T18:19:52Z

tests/functional/replication/queueProcessor.spec.js

+    afterAll(done => {
        httpServer.close();
-        async.parallel([
+        async.series([


This doesn't seem to be strictly related to typescript/jest, is there a reason for this change?

rachedbenmustapha · 2023-02-16T18:20:07Z

tests/functional/notification/NotificationConfigManager.spec.js

        const getCollectionStub = sinon.stub().returns({
            // mock change stream
-            watch: () => new events.EventEmitter(),
+            watch: () => new MockChangeStream(),


This doesn't seem to be strictly related to typescript/jest, is there a reason for this change?

tests/unit/OffsetLedger.spec.js

tests/utils/syntheticbucketd/Dockerfile

rachedbenmustapha · 2023-02-16T18:32:12Z

tests/functional/lib/BackbeatConsumer.spec.js

-                        consumer.unsubscribe();
+                        consumer.pause();


Why this change (and the subscribe/resume one)? Was the test wrong before?

tests/unit/RoleCredentials.spec.js

lib/api/BackbeatAPI.js

…improvement/BB-424-bump-8.6.24

….7/bugfix/BB-366/addGCReadAccountIDs

…nto tmp/octopus/q/8.7

…p/octopus/w/8.7/bugfix/BB-455-clean-shutdown-backbeat-consumer

… and 'q/2458/8.6/bugfix/BB-455-clean-shutdown-backbeat-consumer' into tmp/octopus/q/8.7

…o tmp/octopus/w/8.7/feature/BB-452-delete-notification-versionid

- add eslint-plugin-jest for jest globals - upgrade esling - fix remaining lint issues

- provide minimal package.json - move all files to tests/utils/syntheticbucketd

Issue: BB-295

jbertran force-pushed the improvement/BB-295-bootstrap-ts-compilation branch from 3f5f8fd to 5c27835 Compare October 14, 2022 14:19

scality deleted a comment from bert-e Oct 14, 2022

welansari force-pushed the improvement/BB-295-bootstrap-ts-compilation branch 6 times, most recently from 7d247d7 to 7df7f4d Compare December 15, 2022 15:54

welansari force-pushed the improvement/BB-295-bootstrap-ts-compilation branch from 45cd2d7 to ff1f5dc Compare January 2, 2023 11:14

welansari changed the base branch from development/8.5 to development/8.6 January 2, 2023 11:14

welansari force-pushed the improvement/BB-295-bootstrap-ts-compilation branch from ff1f5dc to 4b4967b Compare January 4, 2023 15:21

welansari requested a review from francoisferrand January 16, 2023 09:52

welansari force-pushed the improvement/BB-295-bootstrap-ts-compilation branch from 4b4967b to 9f2483d Compare January 16, 2023 10:31

francoisferrand reviewed Feb 1, 2023

View reviewed changes

Dockerfile Show resolved Hide resolved

Dockerfile Outdated Show resolved Hide resolved

francoisferrand requested review from nicolas2bert and tmacro February 13, 2023 09:56

tmacro requested changes Feb 13, 2023

View reviewed changes

welansari requested a review from tmacro February 14, 2023 12:16

welansari force-pushed the improvement/BB-295-bootstrap-ts-compilation branch from 1e3adae to ef611a1 Compare February 14, 2023 12:19

welansari requested a review from francoisferrand February 14, 2023 12:20

rachedbenmustapha reviewed Feb 16, 2023

View reviewed changes

tmacro approved these changes Mar 24, 2023

View reviewed changes

Seragonia and others added 4 commits June 22, 2023 16:58

BB-400: bump mongodb to 4.4.21

1250c7c

Merge branch 'improvement/BB-424-bump-8.6.24' into tmp/octopus/w/8.7/…

a3deac2

…improvement/BB-424-bump-8.6.24

Merge branch 'bugfix/BB-415' into tmp/octopus/w/8.7/bugfix/BB-415

651e77f

Merge branch 'bugfix/BB-366/addGCReadAccountIDs' into tmp/octopus/w/8…

1aa6af6

….7/bugfix/BB-366/addGCReadAccountIDs

bert-e and others added 25 commits October 27, 2023 17:05

Merge branches 'w/8.7/bugfix/BB-449' and 'q/2467/8.6/bugfix/BB-449' i…

69a6f74

…nto tmp/octopus/q/8.7

Merge branch 'bugfix/BB-455-clean-shutdown-backbeat-consumer' into tm…

e27dce6

…p/octopus/w/8.7/bugfix/BB-455-clean-shutdown-backbeat-consumer

Merge branches 'w/8.7/bugfix/BB-455-clean-shutdown-backbeat-consumer'…

daa2c72

… and 'q/2458/8.6/bugfix/BB-455-clean-shutdown-backbeat-consumer' into tmp/octopus/q/8.7

Merge branch 'w/8.6/feature/BB-452-delete-notification-versionid' int…

850b910

…o tmp/octopus/w/8.7/feature/BB-452-delete-notification-versionid

BB-295 - introduce typescript and jest

e6754d3

BB-295 - switch to jest

6aa3903

BB-295 - use compiled output in tests

97bc084

BB-295 - catch up jest CLI differences

1183125

BB-295 - fix eslint

bb3b7ed

- add eslint-plugin-jest for jest globals - upgrade esling - fix remaining lint issues

BB-295 - use ts-jest

62c0149

BB-295 - streamline syntheticbucketd container build

3a6c067

- provide minimal package.json - move all files to tests/utils/syntheticbucketd

BB-295 - no parallelism in tests

7bab447

BB-295 - adapt to jest API

9647a57

BB-295 - stop leaking redis connections in BBAPI tests

84979de

BB-295 - stop leaking redis connection in qp tests

b7c8c17

BB-295 - sample migration

4ae2001

BB-295 - fix eslint with ts files

a83468c

BB-295 - move tests to .spec.js

52e3de1

BB-295 - fix missed tests

7a77874

BB-295 - use jest with expression filters instead of paths

7e42bbe

BB-295 - set forceExit on every jest launch

6a80098

BB-295 - fix image build issue

579be61

BB-295 - fix functional tests

3e15903

Fix syntheticbucketd dockerfile to support caching deps in layer

897c063

Issue: BB-295

Fix jest lint warning

3fdd455

Issue: BB-295

francoisferrand force-pushed the improvement/BB-295-bootstrap-ts-compilation branch 2 times, most recently from 7083476 to 54273c6 Compare November 8, 2023 08:07

francoisferrand added 2 commits November 8, 2023 09:42

Reenable bucket conductor test with bucketd

8f77206

Issue: BB-295

Reenable disabled tess

102140b

Issue: BB-295

francoisferrand force-pushed the improvement/BB-295-bootstrap-ts-compilation branch from 980f7e4 to 102140b Compare November 8, 2023 08:42

Conversation

jbertran commented Oct 14, 2022 • edited by welansari Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bert-e commented Oct 14, 2022

Hello jbertran,

Uh oh!

bert-e commented Oct 14, 2022

Incorrect fix version

Uh oh!

jbertran commented Oct 14, 2022

Uh oh!

jbertran commented Oct 14, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rachedbenmustapha Feb 16, 2023

Choose a reason for hiding this comment

Uh oh!

rachedbenmustapha Feb 16, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rachedbenmustapha Feb 16, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

jbertran commented Oct 14, 2022 •

edited by welansari

Loading