Skip to content

Improvement/gdl 14 add reusable prettier diff#212

Merged
bert-e merged 2 commits into
development/8.3from
improvement/GDL-14-add-reusable-prettier-diff
May 13, 2026
Merged

Improvement/gdl 14 add reusable prettier diff#212
bert-e merged 2 commits into
development/8.3from
improvement/GDL-14-add-reusable-prettier-diff

Conversation

@benzekrimaha
Copy link
Copy Markdown
Contributor

Issue: GDL-14

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented May 7, 2026

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented May 7, 2026

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@benzekrimaha benzekrimaha force-pushed the improvement/GDL-14-add-reusable-prettier-diff branch from 0288403 to 3501013 Compare May 7, 2026 18:21
@benzekrimaha benzekrimaha marked this pull request as ready for review May 7, 2026 18:21
@benzekrimaha benzekrimaha requested review from a team, SylvainSenechal and maeldonn May 7, 2026 18:21
Comment thread package.json Outdated
Comment thread README.md Outdated
Copy link
Copy Markdown

@maeldonn maeldonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions

Comment thread bin/scality-prettier-diff Outdated
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how come we need this file ?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed, prettier-diff.js can be run directly just as well...

@benzekrimaha benzekrimaha force-pushed the improvement/GDL-14-add-reusable-prettier-diff branch from 9e4c243 to 7fa5ff3 Compare May 13, 2026 07:42
@benzekrimaha benzekrimaha force-pushed the improvement/GDL-14-add-reusable-prettier-diff branch from ff0bd3d to 8ae4ae7 Compare May 13, 2026 07:44
@benzekrimaha
Copy link
Copy Markdown
Contributor Author

/approve

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented May 13, 2026

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.3

The following branches have NOT changed:

  • development/6.4
  • development/7.10
  • development/7.4
  • development/8.2

Please check the status of the associated issue GDL-14.

Goodbye benzekrimaha.

The following options are set: approve

@bert-e bert-e merged commit 8ae4ae7 into development/8.3 May 13, 2026
1 check passed
@bert-e bert-e deleted the improvement/GDL-14-add-reusable-prettier-diff branch May 13, 2026 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants