Skip to content

Bugfix/arsn 367 id and principal on policy hotfix#2172

Closed
benzekrimaha wants to merge 3 commits intohotfix/7.10.43from
bugfix/ARSN-367-id-and-principal-on-policy-hotfix
Closed

Bugfix/arsn 367 id and principal on policy hotfix#2172
benzekrimaha wants to merge 3 commits intohotfix/7.10.43from
bugfix/ARSN-367-id-and-principal-on-policy-hotfix

Conversation

@benzekrimaha
Copy link
Contributor

@benzekrimaha benzekrimaha commented Oct 2, 2023 •
edited
Loading

Description

Motivation and context

This PR adds support of the Id and principal definition / length constraints on resource and user policy documents

Checklist

Add tests to cover the changes

existing tests modified to cover all changes

@benzekrimaha
ARSN-367:principal change on schema and test add
a20665d 
The maximum length should be 2048 characters
having 31 characters on the fixed length prefix
this explains the 2017 max limit put in the schema

(cherry picked from commit 73c6f41)
@benzekrimaha
ARSN-365:Id added on policy schema and validator
f3db764 
Signed-off-by: Maha Benzekri <maha.benzekri@scality.com>
(cherry picked from commit 9ea39c6)
@benzekrimaha
ARSN-367:Bump arsenal version
e9a9b74
@bert-e
Copy link
Contributor

bert-e commented Oct 2, 2023

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Oct 2, 2023

Incorrect fix version

The Fix Version/s in issue ARSN-367 contains:

  • 7.10.49

  • 7.70.12

  • 8.1.112

Considering where you are trying to merge, I expected to find at least:

  • 7.10.43.1

Please check the Fix Version/s of ARSN-367, or the target
branch of this pull request.

@benzekrimaha benzekrimaha deleted the bugfix/ARSN-367-id-and-principal-on-policy-hotfix branch October 2, 2023 12:26
@benzekrimaha benzekrimaha restored the bugfix/ARSN-367-id-and-principal-on-policy-hotfix branch October 2, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicolas2bert nicolas2bert Awaiting requested review from nicolas2bert

@TeddyAndrieux TeddyAndrieux Awaiting requested review from TeddyAndrieux

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@benzekrimaha @bert-e