fix(mcp): fix support for streamable http#5554
Open
remyleone wants to merge 22 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5554 +/- ##
==========================================
- Coverage 50.35% 50.33% -0.03%
==========================================
Files 338 338
Lines 78574 78651 +77
==========================================
+ Hits 39568 39587 +19
- Misses 37506 37561 +55
- Partials 1500 1503 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
remyleone
force-pushed
the
fix_streamable_http
branch
from
761c10e to
e7f572d
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the MCP server implementation to properly support the MCP “streamable HTTP” transport by switching to the SDK-provided streamable HTTP handler and by ensuring CLI command execution has access to core.Meta when requests arrive over HTTP (i.e., outside the normal CLI bootstrap path).
Changes:
- Replace the custom streamable-HTTP mux/transport wiring with
mcp.NewStreamableHTTPHandler. - Propagate “bootstrap” meta into MCP tool/resource execution contexts (plus a fallback meta injection path).
- Mechanical refactors across the codebase to use newer
reflectkind constants and slice helpers.
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/namespaces/mcp/server/transports.go | Switch streamable HTTP server to the SDK handler + options. |
| internal/namespaces/mcp/server/server.go | Thread base meta into MCPServer; minor server startup logging. |
| internal/namespaces/mcp/server/mcp_tools.go | Add meta injection for tool execution; add fallback client init. |
| internal/namespaces/mcp/server/mcp_tools_test.go | Update tests for the new NewCommandTool signature / server ctor. |
| internal/namespaces/mcp/server/mcp_resources.go | Add meta injection for resource execution; pass base meta into resources. |
| internal/namespaces/mcp/server/loader.go | Pass base meta into tools at load time. |
| internal/namespaces/mcp/server/list_tools.go | Update server construction to pass nil base meta for listing. |
| internal/namespaces/mcp/server/e2e_test.go | Replace in-memory E2E tests with a streamable-HTTP-based smoke test. |
| internal/namespaces/mcp/server/commands.go | Build a baseMeta from the serve command context for HTTP transport. |
| internal/namespaces/mcp/server/annotations_test.go | Update tests for new NewMCPServer / NewCommandTool signatures. |
| internal/gofields/gofields.go | Update pointer kind checks for newer reflect APIs. |
| internal/args/unmarshal.go | Update pointer kind checks + iterate anonymous fields in reverse via slices. |
| internal/args/marshal.go | Update pointer kind checks for newer reflect APIs. |
| internal/args/args.go | Update pointer kind checks + reverse anonymous field traversal via slices. |
| core/reflect.go | Update pointer kind checks for newer reflect APIs. |
| core/human/utils.go | Update pointer kind checks for newer reflect APIs. |
| core/human/marshal.go | Update pointer kind checks for newer reflect APIs. |
| core/human/marshal_func.go | Update pointer kind checks for newer reflect APIs. |
| core/context.go | Make meta extraction nil-safe; avoid panics when meta is absent. |
| core/autocomplete_utils.go | Update pointer kind checks for newer reflect APIs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+214
to
+239
| func injectMetaIfMissing(ctx context.Context, baseMeta *core.Meta) context.Context { | ||
| if core.ExtractClient(ctx) != nil { | ||
| return ctx | ||
| } | ||
| if baseMeta != nil { | ||
| meta := *baseMeta | ||
| meta.OverrideEnv = make(map[string]string) | ||
| maps.Copy(meta.OverrideEnv, baseMeta.OverrideEnv) | ||
|
|
||
| return core.InjectMeta(ctx, &meta) | ||
| } | ||
| // baseMeta is nil - create an authenticated client from environment/config | ||
| client, err := scw.NewClient( | ||
| scw.WithDefaultRegion(scw.RegionFrPar), | ||
| scw.WithDefaultZone(scw.ZoneFrPar1), | ||
| scw.WithUserAgent("scaleway-mcp-server"), | ||
| ) | ||
| if err != nil { | ||
| return ctx // Error will be handled by caller when executing command | ||
| } | ||
|
|
||
| return core.InjectMeta(ctx, &core.Meta{ | ||
| Client: client, | ||
| OverrideEnv: map[string]string{}, | ||
| BinaryName: "scw-mcp", | ||
| }) |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
jremy42
reviewed
May 7, 2026
pypaut
reviewed
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Release note for CHANGELOG: