fix(tracing): drop outcome label and rename export span failure metric

Author: james-cardenas

src/agentex/lib/core/observability/tests/test_tracing_metrics.py

@@ -93,7 +93,7 @@ def test_instruments_exist(self, monkeypatch):
             "export_batches",
             "export_spans",
             "export_batch_failures",
-            "export_spans_failed",
+            "export_span_failures",
             "shutdown_timeouts",
             "shutdown_remaining_items",
         ):

src/agentex/lib/core/observability/tests/test_tracing_metrics_recording.py

@@ -94,7 +94,7 @@ class AuthenticationError(Exception):
             )
 
         mock_metrics.export_batch_failures.add.assert_called_once()
-        mock_metrics.export_spans_failed.add.assert_called_once_with(
+        mock_metrics.export_span_failures.add.assert_called_once_with(
             5,
             {
                 "processor": "sgp",
@@ -116,11 +116,11 @@ def test_record_export_success(self, monkeypatch):
 
         mock_metrics.export_batches.add.assert_called_once_with(
             1,
-            {"processor": "sgp", "event_type": "end", "outcome": "success"},
+            {"processor": "sgp", "event_type": "end"},
         )
         mock_metrics.export_spans.add.assert_called_once_with(
             12,
-            {"processor": "sgp", "event_type": "end", "outcome": "success"},
+            {"processor": "sgp", "event_type": "end"},
         )
 
     def test_record_export_success_accepts_processor_label(self, monkeypatch):
@@ -137,5 +137,5 @@ def test_record_export_success_accepts_processor_label(self, monkeypatch):
 
         mock_metrics.export_batches.add.assert_called_once_with(
             1,
-            {"processor": "other", "event_type": "start", "outcome": "success"},
+            {"processor": "other", "event_type": "start"},
         )

src/agentex/lib/core/observability/tracing_metrics.py

@@ -12,9 +12,8 @@
 Cardinality is bounded:
 - ``event_type``: ``start`` | ``end``
 - ``processor``: ``sgp`` | ``other``
-- ``outcome``: ``success`` | ``failure`` (export counters only)
-- ``http_code``: small fixed set from ``classify_export_error``
-- ``error_class``: small fixed set from ``classify_export_error``
+- ``http_code``: small fixed set from ``classify_export_error`` (failure counters only)
+- ``error_class``: small fixed set from ``classify_export_error`` (failure counters only)
 - ``reason``: ``shutdown`` (drops only)
 - ``phase``: ``start`` | ``end`` (batch drain histograms)
 
@@ -75,20 +74,20 @@ def __init__(self) -> None:
         self.export_batches = meter.create_counter(
             name="agentex.tracing.export.batches",
             unit="1",
-            description="HTTP export batch attempts tagged with outcome",
+            description="Successful HTTP export batches by processor and event type",
         )
         self.export_spans = meter.create_counter(
             name="agentex.tracing.export.spans",
             unit="1",
-            description="Spans included in HTTP export batches tagged with outcome",
+            description="Spans in successful HTTP export batches by processor and event type",
         )
         self.export_batch_failures = meter.create_counter(
             name="agentex.tracing.export.batch_failures",
             unit="1",
             description="Failed HTTP export batches by processor and HTTP status",
         )
-        self.export_spans_failed = meter.create_counter(
-            name="agentex.tracing.export.spans_failed",
+        self.export_span_failures = meter.create_counter(
+            name="agentex.tracing.export.span_failures",
             unit="1",
             description="Spans in failed HTTP export batches by processor and HTTP status",
         )

src/agentex/lib/core/observability/tracing_metrics_recording.py

@@ -103,7 +103,7 @@ def record_export_success(*, event_type: str, span_count: int, processor: str =
     try:
         from agentex.lib.core.observability.tracing_metrics import get_tracing_metrics
 
-        attrs = {"processor": processor, "event_type": event_type, "outcome": "success"}
+        attrs = {"processor": processor, "event_type": event_type}
         metrics = get_tracing_metrics()
         metrics.export_batches.add(1, attrs)
         metrics.export_spans.add(span_count, attrs)
@@ -137,7 +137,7 @@ def record_export_failure(
         }
         metrics = get_tracing_metrics()
         metrics.export_batch_failures.add(1, attrs)
-        metrics.export_spans_failed.add(span_count, attrs)
+        metrics.export_span_failures.add(span_count, attrs)
     except Exception:
         pass
 

tests/lib/core/tracing/processors/test_sgp_tracing_processor.py

@@ -240,11 +240,11 @@ async def test_on_spans_start_records_export_success_metrics(self, monkeypatch):
 
         mock_metrics.export_batches.add.assert_called_once_with(
             1,
-            {"processor": "sgp", "event_type": "start", "outcome": "success"},
+            {"processor": "sgp", "event_type": "start"},
         )
         mock_metrics.export_spans.add.assert_called_once_with(
             n,
-            {"processor": "sgp", "event_type": "start", "outcome": "success"},
+            {"processor": "sgp", "event_type": "start"},
         )
         assert mock_client.spans.upsert_batch.call_count == 1
 

tests/lib/core/tracing/test_span_queue.py

@@ -569,7 +569,7 @@ class ExportError(Exception):
             await queue.shutdown()
 
         mock_metrics.export_batch_failures.add.assert_called_once()
-        mock_metrics.export_spans_failed.add.assert_called_once()
+        mock_metrics.export_span_failures.add.assert_called_once()
 
     async def test_enqueue_overhead_with_metrics_disabled(self, monkeypatch):
         monkeypatch.setenv("AGENTEX_TRACING_METRICS", "0")