Fix redundant '_ms' from duration histogram instruments

Author: james-cardenas

src/agentex/lib/core/observability/tests/test_tracing_metrics.py

@@ -86,10 +86,10 @@ def test_instruments_exist(self, monkeypatch):
             "span_events_enqueued",
             "span_events_dropped",
             "queue_depth",
-            "queue_lag_ms",
+            "queue_lag",
             "batch_items",
             "batch_size",
-            "batch_drain_duration_ms",
+            "batch_drain_duration",
             "export_batches",
             "export_spans",
             "export_batch_failures",

src/agentex/lib/core/observability/tests/test_tracing_metrics_recording.py

@@ -69,7 +69,7 @@ def test_record_batch_coalesced_records_lag(self, monkeypatch):
             )
         mock_metrics.queue_depth.record.assert_called_once_with(3)
         mock_metrics.batch_items.record.assert_called_once_with(2)
-        mock_metrics.queue_lag_ms.record.assert_called_once_with(1000.0)
+        mock_metrics.queue_lag.record.assert_called_once_with(1000.0)
 
     def test_record_export_failure(self, monkeypatch):
         monkeypatch.setenv("AGENTEX_TRACING_METRICS", "1")

src/agentex/lib/core/observability/tracing_metrics.py

@@ -52,8 +52,8 @@ def __init__(self) -> None:
             unit="1",
             description="asyncio queue depth at the start of a drain batch",
         )
-        self.queue_lag_ms = meter.create_histogram(
-            name="agentex.tracing.queue.lag_ms",
+        self.queue_lag = meter.create_histogram(
+            name="agentex.tracing.queue.lag",
             unit="ms",
             description="Max time from enqueue to drain-batch start for items in the batch",
         )
@@ -67,8 +67,8 @@ def __init__(self) -> None:
             unit="1",
             description="Span events in one START or END dispatch phase",
         )
-        self.batch_drain_duration_ms = meter.create_histogram(
-            name="agentex.tracing.batch.drain_duration_ms",
+        self.batch_drain_duration = meter.create_histogram(
+            name="agentex.tracing.batch.drain_duration",
             unit="ms",
             description="Wall time for one START or END _process_items dispatch",
         )

src/agentex/lib/core/observability/tracing_metrics_recording.py

@@ -78,7 +78,7 @@ def record_batch_coalesced(
                 continue
             lag_ms = max(lag_ms, (now - item.enqueued_at) * 1000.0)
         if lag_ms > 0:
-            metrics.queue_lag_ms.record(lag_ms)
+            metrics.queue_lag.record(lag_ms)
     except Exception:
         pass
 
@@ -92,7 +92,7 @@ def record_batch_phase(*, phase: str, size: int, duration_ms: float) -> None:
         attrs = {"phase": phase}
         metrics = get_tracing_metrics()
         metrics.batch_size.record(size, attrs)
-        metrics.batch_drain_duration_ms.record(duration_ms, attrs)
+        metrics.batch_drain_duration.record(duration_ms, attrs)
     except Exception:
         pass