Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions crates/squawk_ide/src/hover.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1581,4 +1581,18 @@ select a$0 from y;
╰╴ ─ hover
");
}

#[test]
fn hover_on_cte_shadowing_table_with_star() {
assert_snapshot!(check_hover("
create table t(a bigint);
with t as (select * from t)
select a$0 from t;
"), @r"
hover: column public.t.a bigint
╭▸
4 │ select a from t;
╰╴ ─ hover
");
}
}
6 changes: 5 additions & 1 deletion crates/squawk_ide/src/resolve.rs
Original file line number Diff line number Diff line change
Expand Up @@ -851,7 +851,11 @@ fn resolve_cte_column(
{
let from_table_name =
Name::new(from_name_ref.syntax().text().to_string());
return resolve_cte_column(name_ref, &from_table_name, column_name);
// Skip recursive CTE lookup if the FROM table has the same name as the current CTE
// (CTEs don't shadow themselves in their own definition)
if from_table_name != *cte_name {
return resolve_cte_column(name_ref, &from_table_name, column_name);
}
}
}
}
Expand Down
Loading