refactor hostkeys and knownhosts classes by moving and exposing their parameters in the relevant parents#412
Closed
stuartrobert wants to merge 2 commits into
Closed
refactor hostkeys and knownhosts classes by moving and exposing their parameters in the relevant parents#412stuartrobert wants to merge 2 commits into
stuartrobert wants to merge 2 commits into
Conversation
saz
reviewed
Jun 30, 2025
saz
reviewed
Jun 30, 2025
|
i would welcome this "breaking change". servers dont need to receive sshkeys. i found this because i started using this puppet module and came looking for how to disable this. |
Owner
|
@stuartrobert can you squash commits and rebase? |
- moved parameters from hostkeys to server - removed use of knownhosts from server class - moved parameters from knownhosts to client - removed knownhosts class - updated data to reflect
bastelfreak
reviewed
May 21, 2026
| @@ -1,5 +1,5 @@ | |||
| # @summary | |||
| # This class manages hostkeys | |||
| # This class manages hostkeys. It is intended to be called from `ssh::server`. | |||
Contributor
There was a problem hiding this comment.
Should the class be marked private with assert_private()?
Owner
|
Fixed with #443 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request (PR) fixes the following issues
Fixes #411