Ignore duplicate access transformers#412
Merged
budak7273 merged 3 commits intoMay 1, 2026
Merged
Conversation
github-project-automation
Bot
moved this to 🆕 New
in Mod Loader (SML), Alpakit, ExampleMod, and Engine
budak7273
moved this from 🆕 New
to 👀 In review
in Mod Loader (SML), Alpakit, ExampleMod, and Engine
budak7273
changed the title
Member
Will merge once Jarno takes a look |
Th3Fanbus
approved these changes
May 1, 2026
Contributor
Th3Fanbus
left a comment
Th3Fanbus
left a comment
There was a problem hiding this comment.
Looks good to me, I like Robb's approach because of its simplicity.
Contributor
Author
|
Tested works correct, also if multiple mods have the same unused transformer |
github-project-automation
Bot
moved this from 👀 In review
to ✅ Completed
in Mod Loader (SML), Alpakit, ExampleMod, and Engine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If two mods define the same accessor transformer, it will generate a duplicates causing builds to fail
found with the following access transformer in two different mods