Publish model versions - added another unit test#221
Merged
samyarpotlapalli merged 8 commits intomasterfrom Aug 8, 2025
Merged
Publish model versions - added another unit test#221samyarpotlapalli merged 8 commits intomasterfrom
samyarpotlapalli merged 8 commits intomasterfrom
Conversation
…and performance monitoring models
Signed-off-by: samyarpotlapalli <posa@unc.edu>
…@unc.edu>I, samyarpotlapalli <posa@unc.edu>, hereby add my Signed-off-by to this commit: c01034e23bd6bd9c3905648223b6d784f68e0693I, samyarpotlapalli <posa@unc.edu>, hereby add my Signed-off-by to this commit: b6078ce3560dcbe18cff09737491861f82d37f78I, samyarpotlapalli <posa@unc.edu>, hereby add my Signed-off-by to this commit: d32a9c4a26513d4a36d9ce45fa2d511ba5cc6f73Signed-off-by: samyarpotlapalli <posa@unc.edu> Signed-off-by: samyarpotlapalli <posa@unc.edu>
…tlapalli <posa@unc.edu>, hereby add my Signed-off-by to this commit: c01034e23bd6bd9c3905648223b6d784f68e0693I, samyarpotlapalli <posa@unc.edu>, hereby add my Signed-off-by to this commit: b6078ce3560dcbe18cff09737491861f82d37f78I, samyarpotlapalli <posa@unc.edu>, hereby add my Signed-off-by to this commit: d32a9c4a26513d4a36d9ce45fa2d511ba5cc6f73Signed-off-by: samyarpotlapalli <posa@unc.edu>
Signed-off-by: samyarpotlapalli <posa@unc.edu>
Signed-off-by: samyarpotlapalli <posa@unc.edu>
Collaborator
Author
|
I tried to fix the Deepsource Python issues, but it's saying the code that I didn't create for create_performance_definition is too complex, but that's already in master so I didn't want to edit that. Also, for DCO, I tried applying that commit message to my previous commits but I'm not sure why it wasn't working. |
Collaborator
You can ignore the DeepSource and DCO issues for now. We need to do a full refactor on the repo to make them happy. |
djm21
approved these changes
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated unit tests for scoreDefinitions and modelManagement. I did not add model version unit testing to publish_model due to not seeing the existing unit test. Publish_model and score_definitions have the same version logic, but I'm happy to add unit testing to all of publish_model if needed. I also broke down score definitions and create_performance_definition to make the code more readable.