This repository was archived by the owner on Jul 24, 2024. It is now read-only.
Open
Conversation
Bringing support for Electron 5, 6, 7 & 8 (windows x32 & x64 only) Looking to expand to all other platforms but can't myself. See https://github.com/sass/node-sass/tree/master/.github/Electron-support.md
Added doc to explain steps required for electron support
Reverted isSupportedEnvironment back to it's original state and removed the function for detecting current electron support
But mor ereading and we can do it without electron-rebuild
Targeted electron versions to stop fails Added artifacts for testing
For electron building
Need to replace electron version with underlying node shown in a comment after each version number
Added new workflows and updated windows version
Oops
Windows ignorance and plain idiocy
Added support for forcing an electron build by adding an argument
Updated workflows for tests
Forgot the node-gyp bump
…into Electron-Test
Member
|
Thank you @glenn2223 for your patience! I'll check if my build machinery can build node-sass for electron as well. |
Author
|
Ref: Commit Fix: Extensions don't honour argument Test 1: Step 5: Line 4 setting arch as Thanks @saper |
nschonni
reviewed
Apr 10, 2020
Contributor
nschonni
left a comment
nschonni
left a comment
There was a problem hiding this comment.
This seems to have a lot more random formatting churn and changes to the overall build setup than the last PR. What has changed that required this?
Author
|
Spelling correction Workflow update Reverted stdio (sorry, was trying to see if I could get a clearer error for an issue I was facing)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for electron v5-8. PR'ing to v5 due to
node-gypbump