Skip to content

Extend 'under-represented wells' feature to other pipelines#5769

Open
sabrine33 wants to merge 10 commits into
developfrom
Y26-090
Open

Extend 'under-represented wells' feature to other pipelines#5769
sabrine33 wants to merge 10 commits into
developfrom
Y26-090

Conversation

@sabrine33
Copy link
Copy Markdown
Contributor

@sabrine33 sabrine33 commented May 12, 2026

  • update the logic behind construct under_rep comments to include all submission types.
  • also update the logic behind comparing aliquots
  • Tested the fix on training on the batches with wrong data (explained here) and it returned the expected/right values.

Closes #

Changes proposed in this pull request

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

sabrine33 added 2 commits May 12, 2026 09:28
…ubmission types.

also update the logic behind comparing aliquots
@sabrine33 sabrine33 linked an issue May 12, 2026 that may be closed by this pull request
2 tasks
@sabrine33 sabrine33 changed the title update the logic behind construct under_rep comments to include all s… Extend 'under-represented wells' feature to other pipelines May 12, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

❌ Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 87.31%. Comparing base (8666389) to head (691bcbf).

Files with missing lines Patch % Lines
app/models/under_rep_well_comments_to_broadcast.rb 95.65% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5769      +/-   ##
===========================================
- Coverage    87.34%   87.31%   -0.04%     
===========================================
  Files         1479     1479              
  Lines        33601    33607       +6     
  Branches      3562     3562              
===========================================
- Hits         29350    29344       -6     
- Misses        4230     4242      +12     
  Partials        21       21              
Flag Coverage Δ
javascript 72.72% <ø> (ø)
ruby 87.32% <95.65%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@andrewsparkes andrewsparkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Clear comments, thorough tests, thanks.

Copy link
Copy Markdown
Contributor

@KatyTaylor KatyTaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things to consider.

Would be good to test it on at least one plate from each of the mentioned pipelines.

Comment thread app/models/under_rep_well_comments_to_broadcast.rb Outdated
Comment thread app/models/under_rep_well_comments_to_broadcast.rb Outdated
Comment thread app/models/under_rep_well_comments_to_broadcast.rb Outdated
Comment thread app/models/under_rep_well_comments_to_broadcast.rb
Comment thread app/models/under_rep_well_comments_to_broadcast.rb
Comment thread app/models/under_rep_well_comments_to_broadcast.rb Outdated
Comment thread app/models/under_rep_well_comments_to_broadcast.rb Outdated
Comment thread app/models/under_rep_well_comments_to_broadcast.rb
Co-authored-by: KatyTaylor <kt17@sanger.ac.uk>
@sabrine33
Copy link
Copy Markdown
Contributor Author

A few things to consider.

Would be good to test it on at least one plate from each of the mentioned pipelines.

I tested on the RNA pipeline but also with different scenarios

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Y26-090 - Extend 'under-represented wells' feature to other pipelines

4 participants