Replace Dimensions with Geometry#62
Merged
Merged
Conversation
mbklein
force-pushed
the
55-56-better-image-geometry
branch
4 times, most recently
from
0f0122d to
04b163c
Compare
mbklein
force-pushed
the
55-56-better-image-geometry
branch
2 times, most recently
from
e17c3db to
f4e9f8a
Compare
Use real tile sizes for info.json (if available) Add tile size probe for TIFF and JPEG 2000
mbklein
force-pushed
the
55-56-better-image-geometry
branch
from
f4e9f8a to
ebc6672
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This PR includes a breaking change that will require a major version bump.
This PR replaces
Dimensions(and theDimensionFunction) with a more inclusiveImageGeometry(andGeometryFunction). Instead of an array of width/height pairs,ImageGeometryincludes depth (pyramid pages) and tile dimensions. This allowsinfo.jsonto report real tile width and height, and provides better options for probing/calculating missing values.Fixes #55
Fixed #56