Skip to content

Set default limit=None for futures_historical_klines* (fetch full range by default) #1607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlosmiei merged 2 commits into from
Sep 15, 2025
Merged

Set default limit=None for futures_historical_klines* (fetch full range by default) #1607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d0d8a1
futures_historical_klines*: default limit=None; cleaned accidental se…
meet-vasita Sep 4, 2025
82e0afe
trigger CI rerun
meet-vasita Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion binance/async_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1731,7 +1731,7 @@ async def futures_continuous_klines(self, **params):
return await self._request_futures_api("get", "continuousKlines", data=params)

async def futures_historical_klines(
self, symbol, interval, start_str, end_str=None, limit=500
self, symbol: str, interval: str, start_str, end_str=None, limit=None
):
return await self._historical_klines(
symbol,
Expand Down
8 changes: 4 additions & 4 deletions binance/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7373,7 +7373,7 @@ def futures_continous_klines(self, **params):
return self._request_futures_api("get", "continuousKlines", data=params)

def futures_historical_klines(
self, symbol, interval, start_str, end_str=None, limit=500
self, symbol: str, interval :str, start_str, end_str=None, limit=None
):
"""Get historical futures klines from Binance

Expand All @@ -7385,7 +7385,7 @@ def futures_historical_klines(
:type start_str: str|int
:param end_str: optional - end date string in UTC format or timestamp in milliseconds (default will fetch everything up to now)
:type end_str: str|int
:param limit: Default 500; max 1000.
:param limit: Default None (fetches full range in batches of max 1000 per request). To limit the number of rows, pass an integer.
:type limit: int

:return: list of OHLCV values (Open time, Open, High, Low, Close, Volume, Close time, Quote asset volume, Number of trades, Taker buy base asset volume, Taker buy quote asset volume, Ignore)
Expand All @@ -7401,7 +7401,7 @@ def futures_historical_klines(
)

def futures_historical_mark_price_klines(
self, symbol, interval, start_str, end_str=None, limit=500
self, symbol: str, interval: str, start_str, end_str=None, limit=None
):
"""Get historical futures mark price klines from Binance

Expand All @@ -7413,7 +7413,7 @@ def futures_historical_mark_price_klines(
:type start_str: str|int
:param end_str: optional - end date string in UTC format or timestamp in milliseconds (default will fetch everything up to now)
:type end_str: str|int
:param limit: Default 500; max 1000.
:param limit: Default None (fetches full range in batches of max 1000 per request). To limit the number of rows, pass an integer.
:type limit: int

:return: list of OHLCV values (Open time, Open, High, Low, Close, Volume, Close time, Quote asset volume, Number of trades, Taker buy base asset volume, Taker buy quote asset volume, Ignore)
Expand Down
Loading