PLASMA-7286: update Cell types by oki1oki · Pull Request #2810 · salute-developers/plasma

oki1oki · 2026-05-27T15:55:55Z

Core

Cell

CellProps теперь принимает стандартные атрибуты HTMLDivElement

What/why changed

CellProps теперь принимает стандартные атрибуты HTMLDivElement

Summary by CodeRabbit

New Features
- Cell component now accepts and properly forwards standard HTML div attributes, enabling greater flexibility when using the component.

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/plasma-asdk@0.378.0-canary.2810.26522573163.0
npm install @salutejs/plasma-b2c@1.620.0-canary.2810.26522573163.0
npm install @salutejs/plasma-core@1.228.0-canary.2810.26522573163.0
npm install @salutejs/plasma-giga@0.347.0-canary.2810.26522573163.0
npm install @salutejs/plasma-homeds@0.347.0-canary.2810.26522573163.0
npm install @salutejs/plasma-hope@1.374.0-canary.2810.26522573163.0
npm install @salutejs/plasma-icons@1.239.0-canary.2810.26522573163.0
npm install @salutejs/plasma-new-hope@0.364.0-canary.2810.26522573163.0
npm install @salutejs/plasma-tokens-b2b@1.56.0-canary.2810.26522573163.0
npm install @salutejs/plasma-tokens-b2c@0.67.0-canary.2810.26522573163.0
npm install @salutejs/plasma-tokens-web@1.71.0-canary.2810.26522573163.0
npm install @salutejs/plasma-tokens@1.140.0-canary.2810.26522573163.0
npm install @salutejs/plasma-typo@0.44.0-canary.2810.26522573163.0
npm install @salutejs/plasma-ui@1.350.0-canary.2810.26522573163.0
npm install @salutejs/plasma-web@1.622.0-canary.2810.26522573163.0
npm install @salutejs/sdds-bizcom@0.352.0-canary.2810.26522573163.0
npm install @salutejs/sdds-cs@0.356.0-canary.2810.26522573163.0
npm install @salutejs/sdds-dfa@0.350.0-canary.2810.26522573163.0
npm install @salutejs/sdds-finai@0.343.0-canary.2810.26522573163.0
npm install @salutejs/sdds-insol@0.347.0-canary.2810.26522573163.0
npm install @salutejs/sdds-netology@0.351.0-canary.2810.26522573163.0
npm install @salutejs/sdds-os@0.22.0-canary.2810.26522573163.0
npm install @salutejs/sdds-platform-ai@0.351.0-canary.2810.26522573163.0
npm install @salutejs/sdds-sbcom@0.352.0-canary.2810.26522573163.0
npm install @salutejs/sdds-scan@0.350.0-canary.2810.26522573163.0
npm install @salutejs/sdds-serv@0.351.0-canary.2810.26522573163.0
npm install @salutejs/core-themes@0.31.0-canary.2810.26522573163.0
npm install @salutejs/plasma-themes@0.52.0-canary.2810.26522573163.0
npm install @salutejs/sdds-themes@0.67.0-canary.2810.26522573163.0
npm install @salutejs/sdds-api-tests@0.9.0-canary.2810.26522573163.0
npm install @salutejs/plasma-cy-utils@0.158.0-canary.2810.26522573163.0
npm install @salutejs/plasma-sb-utils@0.228.0-canary.2810.26522573163.0
npm install @salutejs/plasma-tokens-utils@0.52.0-canary.2810.26522573163.0
# or 
yarn add @salutejs/plasma-asdk@0.378.0-canary.2810.26522573163.0
yarn add @salutejs/plasma-b2c@1.620.0-canary.2810.26522573163.0
yarn add @salutejs/plasma-core@1.228.0-canary.2810.26522573163.0
yarn add @salutejs/plasma-giga@0.347.0-canary.2810.26522573163.0
yarn add @salutejs/plasma-homeds@0.347.0-canary.2810.26522573163.0
yarn add @salutejs/plasma-hope@1.374.0-canary.2810.26522573163.0
yarn add @salutejs/plasma-icons@1.239.0-canary.2810.26522573163.0
yarn add @salutejs/plasma-new-hope@0.364.0-canary.2810.26522573163.0
yarn add @salutejs/plasma-tokens-b2b@1.56.0-canary.2810.26522573163.0
yarn add @salutejs/plasma-tokens-b2c@0.67.0-canary.2810.26522573163.0
yarn add @salutejs/plasma-tokens-web@1.71.0-canary.2810.26522573163.0
yarn add @salutejs/plasma-tokens@1.140.0-canary.2810.26522573163.0
yarn add @salutejs/plasma-typo@0.44.0-canary.2810.26522573163.0
yarn add @salutejs/plasma-ui@1.350.0-canary.2810.26522573163.0
yarn add @salutejs/plasma-web@1.622.0-canary.2810.26522573163.0
yarn add @salutejs/sdds-bizcom@0.352.0-canary.2810.26522573163.0
yarn add @salutejs/sdds-cs@0.356.0-canary.2810.26522573163.0
yarn add @salutejs/sdds-dfa@0.350.0-canary.2810.26522573163.0
yarn add @salutejs/sdds-finai@0.343.0-canary.2810.26522573163.0
yarn add @salutejs/sdds-insol@0.347.0-canary.2810.26522573163.0
yarn add @salutejs/sdds-netology@0.351.0-canary.2810.26522573163.0
yarn add @salutejs/sdds-os@0.22.0-canary.2810.26522573163.0
yarn add @salutejs/sdds-platform-ai@0.351.0-canary.2810.26522573163.0
yarn add @salutejs/sdds-sbcom@0.352.0-canary.2810.26522573163.0
yarn add @salutejs/sdds-scan@0.350.0-canary.2810.26522573163.0
yarn add @salutejs/sdds-serv@0.351.0-canary.2810.26522573163.0
yarn add @salutejs/core-themes@0.31.0-canary.2810.26522573163.0
yarn add @salutejs/plasma-themes@0.52.0-canary.2810.26522573163.0
yarn add @salutejs/sdds-themes@0.67.0-canary.2810.26522573163.0
yarn add @salutejs/sdds-api-tests@0.9.0-canary.2810.26522573163.0
yarn add @salutejs/plasma-cy-utils@0.158.0-canary.2810.26522573163.0
yarn add @salutejs/plasma-sb-utils@0.228.0-canary.2810.26522573163.0
yarn add @salutejs/plasma-tokens-utils@0.52.0-canary.2810.26522573163.0

coderabbitai · 2026-05-27T15:56:05Z

📝 Walkthrough

Walkthrough

The Cell component is updated to accept and forward standard HTML div attributes. The CellProps type now extends HTMLAttributes<HTMLDivElement>, and the cellRoot implementation captures remaining props via rest destructuring and spreads them onto the underlying Root element.

Changes

Cell HTML Attribute Forwarding

Layer / File(s)	Summary
Props type contract and imports `packages/plasma-new-hope/src/components/Cell/Cell.types.ts`	`CellProps` now intersects `HTMLAttributes<HTMLDivElement>` with custom and textbox prop types. `HTMLAttributes` import is added from React. Comment text adjusted.
Props forwarding in cellRoot implementation `packages/plasma-new-hope/src/components/Cell/Cell.tsx`	`cellRoot` captures remaining props via `...rest` destructuring and spreads them onto the `Root` element, enabling standard HTML attributes to flow through.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Poem

🐰 A Cell hops forward with grace,
Now carrying HTML's embrace,
Div attributes flow through without strain,
As props find their rightful lane,
The component's reach expands today! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly and accurately summarizes the main change: updating Cell types to accept standard HTMLDivElement attributes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch PLASMA-7286

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-05-27T15:58:22Z

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-2810/

github-actions · 2026-05-27T16:36:53Z

Documentation preview deployed!

feat(new-hope): update Cell types [PLASMA-7286]

6d5409d

oki1oki temporarily deployed to internal May 27, 2026 15:56 — with GitHub Actions Inactive

oki1oki marked this pull request as ready for review May 27, 2026 16:37

oki1oki requested review from TitanKuzmich, Yakutoc, Yeti-or, neretin-trike and shuga2704 as code owners May 27, 2026 16:37

github-actions Bot removed request for TitanKuzmich, Yakutoc, Yeti-or, neretin-trike and shuga2704 May 27, 2026 16:40

oki1oki requested review from TitanKuzmich and shuga2704 May 27, 2026 16:41

Yakutoc assigned oki1oki May 28, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PLASMA-7286: update Cell types#2810

PLASMA-7286: update Cell types#2810
oki1oki wants to merge 1 commit into
devfrom
PLASMA-7286

oki1oki commented May 27, 2026 •

edited by Salute-Eva

Loading

Uh oh!

coderabbitai Bot commented May 27, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

github-actions Bot commented May 27, 2026

Uh oh!

github-actions Bot commented May 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

oki1oki commented May 27, 2026 • edited by Salute-Eva Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Core

Cell

What/why changed

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

github-actions Bot commented May 27, 2026

Uh oh!

github-actions Bot commented May 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

oki1oki commented May 27, 2026 •

edited by Salute-Eva

Loading

coderabbitai Bot commented May 27, 2026 •

edited

Loading