Document retry_dns failover behavior#69110
Open
tdashelby-cmyk wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Documents the
retry_dnsbehavior when the minion is configured withmaster_type: failover.The current minion code forces
retry_dnsto0during startup in that mode so DNS errors move to the next configured master instead of retrying the same name resolution.What issues does this PR fix or reference?
Fixes #69109
Previous Behavior
The
retry_dnsreference only described the default retry interval and the general0behavior, so the failover-specific override was not visible from the minion configuration docs.New Behavior
The
retry_dnsreference now notes thatmaster_type: failovercauses Salt to setretry_dnsto0during startup to allow failover on DNS errors.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No
Verification
git diff --checkSelect-String -Path doc\ref\configuration\minion.rst -Pattern 'master_type.*failover','retry_dns`` to ``0','conf_minion:: retry_dns'