Bugfix/68577 debian ownership#68719
Draft
harshang03 wants to merge 5 commits intosaltstack:masterfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes Debian package maintainer script ownership/user handling for salt-master and salt-minion so upgrades/reinstalls don’t reset custom unprivileged users back to salt.
Specifically, the preinst/postinst scripts now:
preserve existing debconf user selections,
fall back to user: from /etc/salt/master or /etc/salt/minion when appropriate,
mark debconf entries as seen to avoid unintended resets,
use the resolved user’s primary group for ownership operations.
What issues does this PR fix or reference?
Fixes #68577
Previous Behavior
On Debian package upgrades/reinstalls/reconfigure, ownership on salt directories/files could be reset to default salt/root paths because maintainer scripts overwrote user selection when pidfiles were absent and chowned with default assumptions.
New Behavior
Debian maintainer scripts now preserve configured service users across upgrade/reinstall flows and apply ownership using the resolved user/group, preventing repeated permission regressions for custom unprivileged deployments.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No