Bugfix/68525 pip prerelease upgrade#68713
Draft
harshang03 wants to merge 4 commits intosaltstack:masterfrom
Draft
Bugfix/68525 pip prerelease upgrade#68713harshang03 wants to merge 4 commits intosaltstack:masterfrom
harshang03 wants to merge 4 commits intosaltstack:masterfrom
Conversation
Contributor
|
There is already a PR to fix this #68526 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes pip.installed upgrade behavior so pre-release versions are considered and upgraded to when upgrade=True and pre_releases=True. Also adds a small pip.list_all_versions API enhancement (pre_releases parameter) and unit tests to prevent regressions.
What issues does this PR fix or reference?
Fixes #68525
Previous Behavior
With pip.installed using pkgs, upgrade=True, and pre_releases=True, Salt could skip upgrading to a newer pre-release (including when a specific pre-release like ==1.0.0rc1 is desired) because the version-availability check didn’t consistently include pre-release versions.
New Behavior
When upgrade=True and pre_releases=True, Salt now includes alpha/beta/rc versions when determining the desired upgrade target, allowing upgrades to pre-releases as intended.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No