Draft
Conversation
Contributor
|
As I commented with test results here: #68593 (comment), I believe #68593 is already fixed in master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Prevents self‑referential requisites from creating recursive cycles, improves onchanges evaluation for prereq‑only runs, and adds docs guidance plus a functional test for the same‑ID onchanges case.
What issues does this PR fix or reference?
Fixes #68593
Previous Behavior
States with multiple declarations sharing the same ID could trigger “Recursive requisite found” with onchanges, even for the docs example pattern.
New Behavior
Self‑referential requisites are ignored with a warning, onchanges uses prereq test results when applicable, and the same‑ID example runs without recursive errors.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No