Draft
Conversation
bdrx312
reviewed
Feb 10, 2026
| """ | ||
| Validate the requested runas user on Windows systems. | ||
| """ | ||
| if not runas or not salt.utils.platform.is_windows(): |
Contributor
There was a problem hiding this comment.
This is already checked at line 3043 if salt.utils.platform.is_windows() and runas: https://github.com/saltstack/salt/pull/68708/changes#diff-700b7d75700c9eafa3ee48d01236e59f37b2ed81d998267136fbcc0224766497L3025 .
bdrx312
reviewed
Feb 11, 2026
Comment on lines
+95
to
+96
| if not isinstance(username, str): | ||
| username = str(username) |
Contributor
There was a problem hiding this comment.
This will convert None to 'None' which I think is not desirable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Normalize Windows runas credential handling (including UPNs) and validate domain users before execution in cmd.run/cmd.script, with unit tests for the new validation path.
What issues does this PR fix or reference?
Fixes #68612
Previous Behavior
runas with domain/UPN users could be rejected as “Invalid user” or pass the wrong username/domain to Windows logon APIs, causing failures.
New Behavior
UPN and domain users are validated consistently and passed correctly to Windows logon APIs, allowing runas to succeed for domain accounts.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No