Skip to content

Add force color option for Salt outputters #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sxderp wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Add force color option for Salt outputters #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0a85d8
Add force color option for Salt outputters
Sxderp Apr 12, 2024
81cc3bc
match force-color argument with salt cli
Sxderp Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pepper/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,13 @@ def parse(self):
''')
)

self.parser.add_option(
'--force-color', '--force-colour', dest='output_force_color', default=False, action='store_true',
help=textwrap.dedent('''
Force salt outputter to use color when printing.
''')
Copy link
Collaborator

@barneysowood barneysowood Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to have options match the salt command where possible:

    --force-color, --force-colour
                        Force colored output.

Would you be OK with updating that to support --force-color and --force-colour?
If so, probably best to also update the var to force_color

Copy link
Author

@Sxderp Sxderp Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

)

self.parser.add_option(
'--output-file', dest='output_file', default=None,
help=textwrap.dedent('''
Expand Down
2 changes: 2 additions & 0 deletions pepper/script.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ def __init__(self):
self.cli = PepperCli()
if HAS_SALT:
self.opts = salt.config.client_config(self.cli.options.master)
if self.cli.options.output_force_color:
self.opts['color'] = True
else:
self.opts = {}
if self.cli.options.output_file is not None:
Expand Down