-
Notifications
You must be signed in to change notification settings - Fork 9
Edit of Joanna's edits #1096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit of Joanna's edits #1096
Conversation
Updated summaries for flags.status and flags.created-last-days.
Updated the description and examples sections for clarity.
Updated summaries for various flags in the documentation.
Updated the description and examples in the bundle version report documentation.
Removed the bundle name or ID parameter from the command example.
| - Install a package bundle version in a scratch org and wait 10 minutes for the installation to complete: | ||
|
|
||
| <%= config.bin %> <%= command.id %> --bundle MyPkgBundle1@0.1 --target-org my-scratch-org --target-dev-hub devhub@example.com --wait 10 | ||
| <%= config.bin %> <%= command.id %> --bundle MyPkgBundle1@0.1 --target-org my-scratch-org --dev-hub-org devhub@example.com --wait 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@btrn11 : note that the dev hub flag for this command is currently --dev-hub-org, which is different from all the others (--target-dev-hub). Is that intentional, or a mistake? If you update the flag name to be consistent with other commands, please update the examples back. Thanks!
|
@btrn11 , @j-nolasco : I had a few small tweaks to Joanna's edits, so I create a PR off of her PR to make it easier for you. I find that lots of comments on the original PR is confusing... Let me know if you have any questions! If you agree with my suggestions, merge my PR into Joanna's and then Joanna's into main. (you know that :-) ) Thanks! |
j-nolasco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! Thank you!
aafee20
into
j-nolasco-edit-package-bundle-messages
What does this PR do?
edit
What issues does this PR fix or reference?
@w-@