-
Notifications
You must be signed in to change notification settings - Fork 9
@W-19830917@ fix: fix bundle cli issues dev preview (plugin-packaging) #1060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jshackell-sfdc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my small edits.
Co-authored-by: Juliet Shackell <63259011+jshackell-sfdc@users.noreply.github.com>
Co-authored-by: Juliet Shackell <63259011+jshackell-sfdc@users.noreply.github.com>
…cli/plugin-packaging into btrn11/fix-bundle-dev-preview
Co-authored-by: Juliet Shackell <63259011+jshackell-sfdc@users.noreply.github.com>
| ], | ||
| "flagAliases": ["apiversion", "targetusername", "u"], | ||
| "flagChars": ["b", "d", "o", "w"], | ||
| "flags": ["api-version", "bundle", "dev-hub-org", "flags-dir", "json", "loglevel", "target-org", "verbose", "wait"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the target-dev-hub org flag changed to dev-hub-org which is a breaking change, and 3 month warning before changing is required
| flags['package-install-request-id'], | ||
| flags['target-org'].getConnection(flags['api-version']) | ||
| ); | ||
| this.display(result, flags.verbose); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does --verbose do now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need verbose here for now




@W-19830917@
What does this PR do?
What issues does this PR fix or reference?